commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From henrib <hen...@apache.org>
Subject Re: [VOTE] Release JEXL 2.1 based on RC3
Date Sun, 11 Dec 2011 19:27:17 GMT
On checkstyle, 3 of them are empty statements that are known - been there for
long - and the other are Javadoc on deprecated methods introduced to ensure
binary compatibility.

On PMD, I've never tried to configure it correctly; there was already a lot
of clutter in 1.1... 
A lot of the issues come from number of methods - but there is no choice
since we derive/implement either Javacc generated code or List (at least for
3/4) and in the former case, a lot of import (one per type of ASTNode).
Another lot are the x != y conditions; PMD says "bad style", I tend to like
it to avoid long imbricated "if" chains and a "fail early" workflow.
The use of == on object references instead of "equals" is another "bad"
habit I tend to use for special cases / constant values. For instance,
trying to make a difference between an empty but modifiable list/map and the
empty non-modifiable instance; this avoids null checking later on
(iteration, access, etc).
And the last bunch is parameter reuse which again, is convenient when using
'null' as marker for default value.
When you factor those out, there is not much left (cyclomatic
complexity...).

Anyway, those are not new. May be I tend to focus too much on checkstyle,
find bugs and cobertura to give me a quality assessment.
I'll try to see if anything can be either better configured or "styled"
better in v3.
Cheers,
Henrib



--
View this message in context: http://apache-commons.680414.n4.nabble.com/VOTE-Release-JEXL-2-1-based-on-RC3-tp4174001p4183636.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message