Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B38017761 for ; Tue, 29 Nov 2011 02:36:05 +0000 (UTC) Received: (qmail 51977 invoked by uid 500); 29 Nov 2011 02:36:05 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 51854 invoked by uid 500); 29 Nov 2011 02:36:04 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 51846 invoked by uid 99); 29 Nov 2011 02:36:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 02:36:04 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of SRS0=+/2N=6L=m4x.org=sebastien.brisard@bounces.m4x.org designates 129.104.30.34 as permitted sender) Received: from [129.104.30.34] (HELO mx1.polytechnique.org) (129.104.30.34) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2011 02:35:55 +0000 Received: from mail-vw0-f43.google.com (mail-vw0-f43.google.com [209.85.212.43]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 8599214059825 for ; Tue, 29 Nov 2011 03:35:34 +0100 (CET) Received: by vbbfq11 with SMTP id fq11so6588083vbb.30 for ; Mon, 28 Nov 2011 18:35:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.20.78 with SMTP id l14mr45768913vde.79.1322534133501; Mon, 28 Nov 2011 18:35:33 -0800 (PST) Received: by 10.52.74.5 with HTTP; Mon, 28 Nov 2011 18:35:33 -0800 (PST) In-Reply-To: References: <4ED3DF1C.2090202@gmail.com> Date: Tue, 29 Nov 2011 03:35:33 +0100 Message-ID: Subject: Re: [math] Inconsistencies (bugs) in PascalDistribution? From: =?ISO-8859-1?Q?S=E9bastien_Brisard?= To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Tue Nov 29 03:35:34 2011 +0100 (CET)) X-Org-Mail: sebastien.brisard.1997@polytechnique.org X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Flag: No, tests=bogofilter, spamicity=0.028101, queueID=C95EB1405982A Hi Mikkel > > Thanks for discovering this! I did the implementation, and apparently > assumed notation as the referred source. Sorry for this. > I think there is nothing wrong in the source. Only, you adopted a different definition of the random variable represented by the implemented PascalDistribution: 1. In wikipedia, the r-parameter is the total number of failures, 2. In the CM implementation, the Javadoc states that r is the total number of successes, and the PMF is (correctly) derived accordingly. > > We should also check the variance - this might be suffering from wrong > notation as well. > Yes, I'll do that, too! > > Cheers, Mikkel. > > Now is not a good time to work on o.a.c.m.distribution, since Christian is working on MATH-703. Once this is done, I'll commit a patch to correct this. You will be very welcome to review the changes (except of course if you want to alter your baby yourself ;) ). S=E9bastien --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org