Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAFC17BE1 for ; Fri, 25 Nov 2011 11:10:25 +0000 (UTC) Received: (qmail 64725 invoked by uid 500); 25 Nov 2011 11:10:25 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 64629 invoked by uid 500); 25 Nov 2011 11:10:25 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 64621 invoked by uid 99); 25 Nov 2011 11:10:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2011 11:10:25 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of phil.steitz@gmail.com designates 209.85.161.171 as permitted sender) Received: from [209.85.161.171] (HELO mail-gx0-f171.google.com) (209.85.161.171) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Nov 2011 11:10:18 +0000 Received: by ggnr4 with SMTP id r4so5186675ggn.30 for ; Fri, 25 Nov 2011 03:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:references:from:content-type:x-mailer:in-reply-to :message-id:date:to:content-transfer-encoding:mime-version; bh=LLSM2DUACVDWwOO+X1fCb21f/hLOXtOvoKTPWNV/rEA=; b=mNO4GN6/10rKe7ZwWV7/3mUL/1Y5PUHxxqNa1q50f9L5I95oYhTr04mG8ZsycIkoXA z2/p6cTe53aHyWXfhmwquMcuguTLdfn+Ul60hCLDRslcoFFEu2m6nEZOMgRxkhfmsUPm TfbYI9xZdRiKCdimT2VCVbzUq8FU6AznBcn1A= Received: by 10.236.154.201 with SMTP id h49mr43858262yhk.2.1322219397694; Fri, 25 Nov 2011 03:09:57 -0800 (PST) Received: from [10.74.137.140] (mobile-166-147-119-029.mycingular.net. [166.147.119.29]) by mx.google.com with ESMTPS id x17sm61010511anj.18.2011.11.25.03.09.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Nov 2011 03:09:56 -0800 (PST) Subject: Re: [math] javadoc implicit formatting rules References: From: Phil Steitz Content-Type: text/plain; charset=utf-8 X-Mailer: iPhone Mail (9A405) In-Reply-To: Message-Id: Date: Fri, 25 Nov 2011 06:09:52 -0500 To: Commons Developers List Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) X-Virus-Checked: Checked by ClamAV on apache.org One more point on this. "Consistency" as some sort of independent goal by i= tself has no place in open source software. We need to keep our eyes on the= prize, which is making it easy for users to understand and use the software= and for volunteers to get involved. To the extent that consistent API and d= oco design contributes to these goals, great. But arcane rules or excessive= ly complicated APIs that make it harder for people to use the software and g= et involved are to be avoided. Phil On Nov 25, 2011, at 2:13 AM, S=C3=A9bastien Brisard wrote: > Hi, > here are a few questions about the implicit rules in use in CM for > formatting Javadoc comments, that I've wanted to post for a long time. > Since I'm now reviewing other people's patches, I think it's high time > to clear these questions up. If I'm not mistaken, > (1) every @param tag should start with a capital letter and end with a per= iod > (2) every @return tag should end with a period > When I first submitted a patch (and it was corrected accordingly), I > was a little surprised, since it is in contradiction with conventions > [1] which I (and obviously, others) was used to > (3) Regarding @param tags: "The description begins with a lowercase > letter if it is a phrase (contains no verb), or an uppercase letter if > it is a sentence. End the phrase with a period only if another phrase > or sentence follows it." > (4) Regarding @return tags: "Use the same capitalization and > punctuation as you used in @param." >=20 > I'm not saying these conventions are good/bad. However, they are > consistent with automatic tags (eg "Specified by", which do *not* end > with a period). Besides, I think rules (1) and (2) are not > consistently enforced throughout CM (to take but one example: I > constantly find myself reverting to my old habits...) and so I'm > reluctant to correct other people's work to try and comply with rules > I'm not absolutely sure everyone agrees about. >=20 > I think it would be nice if everyone who is particularly attached to > an unstated rule just states it. We could then gather all those rules > in the Developers resources section of the website (I can do that, > please just write up the list in this thread). This would allow us, > and others, to refer to this document in order to ensure homogeneity > throughout the whole library. >=20 > What do you think? Best regards, > S=C3=A9bastien >=20 > [1] http://www.oracle.com/technetwork/java/javase/documentation/index-1378= 68.html#tag >=20 >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org >=20 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org