Return-Path: 
 <dev-return-131412-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-dev-archive@www.apache.org
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B1EC39686
	for <apmail-commons-dev-archive@www.apache.org>;
 Wed, 30 Nov 2011 17:12:14 +0000 (UTC)
Received: (qmail 72476 invoked by uid 500); 30 Nov 2011 17:12:14 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 72389 invoked by uid 500); 30 Nov 2011 17:12:14 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 72381 invoked by uid 99); 30 Nov 2011 17:12:14 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2011 17:12:14 +0000
X-ASF-Spam-Status: No, hits=2.0 required=5.0
	tests=SPF_NEUTRAL,URI_HEX
X-Spam-Check-By: apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Received: from [216.139.236.26] (HELO sam.nabble.com) (216.139.236.26)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2011 17:12:07 +0000
Received: from joe.nabble.com ([192.168.236.139])
	by sam.nabble.com with esmtp (Exim 4.72)
	(envelope-from <henrib@apache.org>)
	id 1RVnhC-0007Yf-Ll
	for dev@commons.apache.org; Wed, 30 Nov 2011 09:11:46 -0800
Date: Wed, 30 Nov 2011 09:11:46 -0800 (PST)
From: henrib <henrib@apache.org>
To: dev@commons.apache.org
Message-ID: <1322673106665-4123859.post@n4.nabble.com>
In-Reply-To: 
 <CAOGo0Vb_YJWh+g90QxdX439vGS6QhsUUMasYp3Kcy50ZRns6DA@mail.gmail.com>
References: 
 <CAOGo0Va9j99ZhMe0r2Yzrj=nkv0ueUPm1hrKMAgBEV-HunDRVQ@mail.gmail.com>
 <1322490914334-4115380.post@n4.nabble.com>
 <CAOGo0VaYvHKcaRHp_--PEzf6yVt5K3-aaD4AiTi6kuaawSWdww@mail.gmail.com>
 <1322495712321-4115683.post@n4.nabble.com>
 <CAOGo0Vaf_fVFmfJ+igA-rEEt7UW9wBUeh6gbthcPvqDhCOuw7Q@mail.gmail.com>
 <CAOGo0VaKt0sJwtqgOQ4ASRGM9JVeML-LBHV7jRnOU9opgObpGw@mail.gmail.com>
 <CAOGo0VagDVmQnZ6w-g-2Bj43vaOz6V0uMHkQWMPgFAtXg3VD4Q@mail.gmail.com>
 <1322667248491-4123418.post@n4.nabble.com>
 <CAOGo0Vb_YJWh+g90QxdX439vGS6QhsUUMasYp3Kcy50ZRns6DA@mail.gmail.com>
Subject: Re: [JEXL] binary compatibility
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


About Was: Dear #{p} Doe; Now: Dear ${p} Doe; 
As stated, the issue was that preparing a deferred expression must always
return an immediate (even composite) expression. When preparing "Dear #{p}
${name};" , the immediate ${name} will be evaluated - 'name' is the set of
variables - and the preparation of the inner-deferred #{p} leads to another
immediate ${p} thus the  expression "Dear ${p} Doe; " - where the set of
variables is 'p'.
Since asString() must return the stringified form of the expression, it's
pretty essential that this behavior remains as is which is correct.

About JEXL-83 - which is an issue you reported - and its fix which lead to
the JexlThreadedArithmetic, the behavior is documented in the Javadoc @
setLenient():
     * <p>This method is <em>not</em> thread safe; it should be called as an
optional step of the JexlEngine initialization code before expression
creation &amp; evaluation.</p>
      * <p>As of 2.1, you need a JexlThreadedArithmetic instance for this
call to also modify the JexlArithmetic
     * leniency behavior.</p>
The rationale is pretty well documented in the issue itself.
I'd vote for throwing an UnsupportedOperationException with the same message
(or log an error if silent?) and document the change explicitly in the
release notes.


--
View this message in context: http://apache-commons.680414.n4.nabble.com/JEXL-binary-compatibility-tp4114818p4123859.html
Sent from the Commons - Dev mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org