commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [math] replace AbstractContinuousDistribution.getSolverAbsoluteAccuracy() with AbstractContinuousDistribution.getSolver()
Date Sun, 06 Nov 2011 07:24:03 GMT
On 11/6/11 12:18 AM, S├ębastien Brisard wrote:
>> +1, but your observation above then leads to the question where are
>> you going to get this value from?  There may not be a solver to read
>> it from.  I guess the default impl in the base class could just
>> return BaseAbstractUnivariateRealSolver.DEFAULT_FUNCTION_VALUE_ACCURACY.
>>
>> Phil
>>
> Ah, that's one option I didn't think of. I intended to follow the same
> scheme as for getSolverAbsoluteAccuracy(), which returns
> solverAbsoluteAccuracy (private field), possibly initialized with
> DEFAULT_SOLVER_ABSOLUTE_ACCURACY (see AbstractContinuousDistribution).
> Actually, using the BaseAbstractUnivariateRealSolver default value is
> probably better. However, these default values are private... So maybe
> we will have to select reasonable default values here.

Ugh.  I remember complaining about that (the fact that the defaults
were made private) for precisely this kind of reason.  Have to clone
the value, I guess and keep it in synch with whatever Brent uses.

Phil
> S├ębastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message