Return-Path: 
 <dev-return-129979-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-dev-archive@www.apache.org
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E6B647D41
	for <apmail-commons-dev-archive@www.apache.org>;
 Sun,  2 Oct 2011 21:24:00 +0000 (UTC)
Received: (qmail 17757 invoked by uid 500); 2 Oct 2011 21:24:00 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 17656 invoked by uid 500); 2 Oct 2011 21:24:00 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 17647 invoked by uid 99); 2 Oct 2011 21:24:00 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Oct 2011 21:24:00 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.220.171 as permitted sender)
Received: from [209.85.220.171] (HELO mail-vx0-f171.google.com)
 (209.85.220.171)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Oct 2011 21:23:54 +0000
Received: by vcbfo13 with SMTP id fo13so3506819vcb.30
        for <dev@commons.apache.org>; Sun, 02 Oct 2011 14:23:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=xYjGxL0f1UVxmJrFWgwq/1L6XGTkznKfUJPpnB2lmuU=;
        b=aqwtznpHDcX9PMmj2kRU9lgNXJgX6AAu8aTo0To7j2HxX78tcKInGD95Pxy5J4CQOJ
         RJDIxflZO+CjiWpAWw9Rg488elG7daRWHltZhU8qxmT9QB7bZN+P2vGgYVfyaezB5Nft
         nfpE0YNpjhxPWptQrOSFG92NPlMdjJiEay7k0=
MIME-Version: 1.0
Received: by 10.52.29.75 with SMTP id i11mr13962462vdh.296.1317590613694; Sun,
 02 Oct 2011 14:23:33 -0700 (PDT)
Received: by 10.220.155.147 with HTTP; Sun, 2 Oct 2011 14:23:33 -0700 (PDT)
In-Reply-To: <20111002185751.7FCFA2388962@eris.apache.org>
References: <20111002185751.7FCFA2388962@eris.apache.org>
Date: Sun, 2 Oct 2011 22:23:33 +0100
Message-ID: 
 <CAOGo0VZt5iLB4h-riC-AsDD6JXHNLRPLp_iJsR0BJZ_aBHF-uQ@mail.gmail.com>
Subject: Re: svn commit: r1178220 - /commons/proper/io/trunk/build.xml
From: sebb <sebbaz@gmail.com>
To: dev@commons.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org

On 2 October 2011 19:57,  <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Sun Oct =A02 18:57:51 2011
> New Revision: 1178220
>
> URL: http://svn.apache.org/viewvc?rev=3D1178220&view=3Drev
> Log:
> Update to JUnit 4.10 from 3.8.1. Use includeantruntime=3D"false" for repe=
atable builds.
>
> Modified:
> =A0 =A0commons/proper/io/trunk/build.xml
>
> Modified: commons/proper/io/trunk/build.xml
> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/build.xml?rev=
=3D1178220&r1=3D1178219&r2=3D1178220&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- commons/proper/io/trunk/build.xml (original)
> +++ commons/proper/io/trunk/build.xml Sun Oct =A02 18:57:51 2011
> @@ -153,13 +153,14 @@
>
> =A0 <target name=3D"compile" depends=3D"init" description=3D"Compile">
>
> - =A0 =A0<javac =A0srcdir=3D"${source.home}"
> + =A0 =A0<javac srcdir=3D"${source.home}"
> =A0 =A0 =A0 =A0 =A0 =A0destdir=3D"${build.home}/classes"
> - =A0 =A0 =A0 =A0 =A0 =A0 source=3D"${compile.source}"
> - =A0 =A0 =A0 =A0 =A0 =A0 target=3D"${compile.target}"
> - =A0 =A0 =A0 =A0 =A0 =A0 debug=3D"${compile.debug}"
> - =A0 =A0 =A0 deprecation=3D"${compile.deprecation}"
> - =A0 =A0 =A0 =A0 =A0optimize=3D"${compile.optimize}">
> + =A0 =A0 =A0 =A0 =A0 source=3D"${compile.source}"
> + =A0 =A0 =A0 =A0 =A0 target=3D"${compile.target}"
> + =A0 =A0 =A0 =A0 =A0 debug=3D"${compile.debug}"
> + =A0 =A0 =A0 =A0 =A0 deprecation=3D"${compile.deprecation}"
> + =A0 =A0 =A0 =A0 =A0 optimize=3D"${compile.optimize}"
> + =A0 =A0 =A0 =A0 =A0 includeantruntime=3D"false">
> =A0 =A0 =A0 <classpath refid=3D"compile.classpath"/>
> =A0 =A0 </javac>
> =A0 </target>
> @@ -173,7 +174,8 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0destdir=3D"${build.home}/test-classes"
> =A0 =A0 =A0 =A0 =A0 =A0 =A0debug=3D"${compile.debug}"
> =A0 =A0 =A0 =A0 =A0 =A0 =A0deprecation=3D"${compile.deprecation}"
> - =A0 =A0 =A0 =A0 =A0 =A0 optimize=3D"${compile.optimize}">
> + =A0 =A0 =A0 =A0 =A0 =A0 optimize=3D"${compile.optimize}"
> + =A0 =A0 =A0 =A0 =A0 =A0 includeantruntime=3D"false">
> =A0 =A0 =A0 =A0 =A0 <classpath refid=3D"test.classpath"/>
> =A0 =A0 =A0 </javac>
> =A0 =A0 </target>
> @@ -335,7 +337,7 @@
> =A0 =A0 =A0 =A0 <mkdir dir=3D"${download.lib.dir}" />
> =A0 =A0 =A0 =A0 <get dest=3D"${download.lib.dir}/junit.jar"
> =A0 =A0 =A0 =A0 =A0 =A0 usetimestamp=3D"true" ignoreerrors=3D"true"
> - =A0 =A0 =A0 =A0 =A0 =A0src=3D"http://www.ibiblio.org/maven/junit/jars/j=
unit-3.8.1.jar"/>
> + =A0 =A0 =A0 =A0 =A0 =A0src=3D"https://github.com/downloads/KentBeck/jun=
it/junit-4.10.jar"/>

-1

That does not fix the problem of the stale JUnit version - it just
postpones it until the next version change.
Which is what caused the original issue.

The junit version should be defined - once - as a property, and used
everywhere else by referencing the property.

There should probably be a check of the jar MD5 too, but that is a
separate issue.

> =A0 =A0 </target>
>
> =A0</project>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org