Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76DE074CD for ; Wed, 26 Oct 2011 14:56:10 +0000 (UTC) Received: (qmail 77779 invoked by uid 500); 26 Oct 2011 14:56:10 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 77706 invoked by uid 500); 26 Oct 2011 14:56:09 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 77698 invoked by uid 99); 26 Oct 2011 14:56:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2011 14:56:09 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com designates 209.85.210.171 as permitted sender) Received: from [209.85.210.171] (HELO mail-iy0-f171.google.com) (209.85.210.171) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2011 14:56:05 +0000 Received: by iaen33 with SMTP id n33so2609702iae.30 for ; Wed, 26 Oct 2011 07:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=I8ozTPuBlZ1+flC8BdQ08xGtakwhTsyTrFSVcKsLay4=; b=j2D4JBjpWCy7OrLANbOfJBY0Hz1BfcUqngWeiuq9OBd/0boQ6k4nszIX1SSRoORp2T 3xeEAaYZF+sxkdYsDaddwxUHeDOnmtYeHUk9ZptxNElp1cBfWYfH3zgYDrlVwyfu1XY7 o6IrLgZ0eUX8z4OS1yu0lrUl2q33aQSUs44QI= MIME-Version: 1.0 Received: by 10.231.24.96 with SMTP id u32mr1985525ibb.61.1319640944998; Wed, 26 Oct 2011 07:55:44 -0700 (PDT) Received: by 10.231.31.136 with HTTP; Wed, 26 Oct 2011 07:55:44 -0700 (PDT) In-Reply-To: <4EA7CACC.1090409@apache.org> References: <8762jcs68i.fsf@v35516.1blu.de> <4EA7CACC.1090409@apache.org> Date: Wed, 26 Oct 2011 10:55:44 -0400 Message-ID: Subject: Re: [VOTE] Release Compress 1.3 based on RC1 From: Gary Gregory To: Commons Developers List Content-Type: multipart/alternative; boundary=001517741428c1fad004b034d973 --001517741428c1fad004b034d973 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2011 at 4:54 AM, Emmanuel Bourg wrote: > +0 > > The test coverage of Pack200CompressorInputStream is a bit low, the read > methods do not seem to be tested. > > Also in the matches() method the constant '4' could be replaced by > CAFE_DOOD.length > > Emmanuel Bourg In the same vein, in trunk now, the following have 0% code coverage according to Cobertura: - Lister - DumpArchiveConstants: How can it have 0% when it is used? Does Cobertura know how to deal with enums? - DumpArchiveException - InvalidFormatException - ShortFileException - UnrecognizedFormatException - UnsupportedCompressionAlgorithmException - TarArchiveSparseEntry - Zip64RequiredException - ZipConstants: Same oddity as above? - ZipFile$BoundedInputStream - CompressorException - Rand The trunk POM uses cobertura-maven-plugin 2.2 (=3D Cobertura 1.9) and not t= he latest 2.5.1 (=3D Cobertura 1.9.4.1). With the latest plugin, the number are a little worse overall and for some classes a little better. The report is more detailed with other classes, with some annon inner classes (...$1) added for example. I've updated the POM in SVN trunk. FYI, reqs are Maven 2.0.8 and Java 5, so we are good. Gary > > > > Le 26/10/2011 06:54, Stefan Bodewig a =C3=A9crit : > >> Compress 1.3 RC1 is available for review here: >> >> http://people.apache.org/~**bodewig/commons-compress/ >> >> Maven artifacts are here: >> https://repository.apache.org/**content/repositories/** >> orgapachecommons-101/org/**apache/commons/commons-**compress/1.3/ >> >> Details of changes since 1.1 are in the release notes: >> http://people.apache.org/~**bodewig/commons-compress/** >> RELEASE-NOTES.txt >> http://people.apache.org/~**bodewig/commons-compress/site/** >> changes-report.html >> >> I have tested this with Sun JDK 1.5 and OpenJDK 1.6 using maven2. >> >> The tag is here (revision 1189016): >> http://svn.apache.org/viewvc/**commons/proper/compress/tags/** >> COMPRESS_1.3_RC1/ >> >> Site: >> http://people.apache.org/~**bodewig/commons-compress/site/ >> >> Clirr Report (compared to 1.2): >> http://people.apache.org/~**bodewig/commons-compress/site/** >> clirr-report.html >> >> RAT Report: >> http://people.apache.org/~**bodewig/commons-compress/site/** >> rat-report.html >> >> Votes, please. This vote will close in 72 hours, 0500 GMT 29-October >> 2011 >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> >> ------------------------------**------------------------------**--------= - >> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --=20 E-Mail: garydgregory@gmail.com | ggregory@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --001517741428c1fad004b034d973--