Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 550B09183 for ; Sat, 29 Oct 2011 19:53:05 +0000 (UTC) Received: (qmail 98061 invoked by uid 500); 29 Oct 2011 19:53:04 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 97971 invoked by uid 500); 29 Oct 2011 19:53:04 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 97963 invoked by uid 99); 29 Oct 2011 19:53:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 19:53:04 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com designates 209.85.160.171 as permitted sender) Received: from [209.85.160.171] (HELO mail-gy0-f171.google.com) (209.85.160.171) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2011 19:52:57 +0000 Received: by gyg13 with SMTP id 13so7999378gyg.30 for ; Sat, 29 Oct 2011 12:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=NNT4M6Kv5BVHijCc6GMm+M3wUc2ZpYNlcZrKU6y/QDE=; b=MdSLie4v8Vde3GdX0o/GvdcWF12kzVvlPDxPeoC9Ksyd41ieAFTzmtSlki9rXtcgA0 bfZnFpk6Kq+Q/FKx9QagatSYp1TSqtMBw7mEPkSHEeyfKQHEGFcjp/nDMJsWIMmZQJBO 9157gGz+bxgY7/EHfLnYJDOxoGCwRCDf/tfYw= MIME-Version: 1.0 Received: by 10.150.59.1 with SMTP id h1mr6559884yba.90.1319917955023; Sat, 29 Oct 2011 12:52:35 -0700 (PDT) Sender: simone.tripodi@gmail.com Received: by 10.150.51.15 with HTTP; Sat, 29 Oct 2011 12:52:34 -0700 (PDT) In-Reply-To: References: <20111029112121.32E2423889EA@eris.apache.org> Date: Sat, 29 Oct 2011 21:52:34 +0200 X-Google-Sender-Auth: ZuxO9n64IURW0B3YisKqYjvDpLM Message-ID: Subject: Re: svn commit: r1194875 - in /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance: LocalReferenceImpl.java OrderedReturn.java package-info.java From: Simone Tripodi To: Commons Developers List , adrian@cumiskey.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org > There's quite a > bit of that "retro" feel hanging around the OGNL code, I'll be joining > Maurizio to help freshen that up a little in the coming days. Sure, just to cite myself: > Anyway I like it, variables prefixed with '_' look so '90 to me :) anyway I'm not just sure how it is related to checkstyle ;) Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sat, Oct 29, 2011 at 9:37 PM, Adrian Cumiskey wrote: > I really wish that I wasn't old enough to remember the days of 1-3 charac= ter > variable names and C++ style '_' variable name prefixing! =C2=A0There's q= uite a > bit of that "retro" feel hanging around the OGNL code, I'll be joining > Maurizio to help freshen that up a little in the coming days. > > Cheers, Adrian. > > On 29 October 2011 06:46, Simone Tripodi wrote= : > >> Hola Mau >> that's a fields renaming more than checkstyle issues, just to properly >> record changes. >> Anyway I like it, variables prefixed with '_' look so '90 to me :) >> Thanks for taking care! >> Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> >> >> On Sat, Oct 29, 2011 at 1:21 PM, =C2=A0 wrote: >> > Author: mcucchiara >> > Date: Sat Oct 29 11:21:20 2011 >> > New Revision: 1194875 >> > >> > URL: http://svn.apache.org/viewvc?rev=3D1194875&view=3Drev >> > Log: >> > OGNL-11: fixed checkstyle errors >> > >> > Modified: >> > >> =C2=A0commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/en= hance/LocalReferenceImpl.java >> > >> =C2=A0commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/en= hance/OrderedReturn.java >> > >> =C2=A0commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/en= hance/package-info.java >> > >> > Modified: >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= LocalReferenceImpl.java >> > URL: >> http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org= /apache/commons/ognl/enhance/LocalReferenceImpl.java?rev=3D1194875&r1=3D119= 4874&r2=3D1194875&view=3Ddiff >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= LocalReferenceImpl.java >> (original) >> > +++ >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= LocalReferenceImpl.java >> Sat Oct 29 11:21:20 2011 >> > @@ -26,17 +26,17 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 implements LocalReference >> > =C2=A0{ >> > >> > - =C2=A0 =C2=A0private final String _name; >> > + =C2=A0 =C2=A0private final String name; >> > >> > - =C2=A0 =C2=A0private final Class _type; >> > + =C2=A0 =C2=A0private final Class type; >> > >> > - =C2=A0 =C2=A0private final String _expression; >> > + =C2=A0 =C2=A0private final String expression; >> > >> > =C2=A0 =C2=A0 public LocalReferenceImpl( String name, String expressio= n, Class >> type ) >> > =C2=A0 =C2=A0 { >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0_name =3D name; >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0_type =3D type; >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0_expression =3D expression; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0this.name =3D name; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0this.type =3D type; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0this.expression =3D expression; >> > =C2=A0 =C2=A0 } >> > >> > =C2=A0 =C2=A0 /** >> > @@ -44,7 +44,7 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 =C2=A0*/ >> > =C2=A0 =C2=A0 public String getName() >> > =C2=A0 =C2=A0 { >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0return _name; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0return name; >> > =C2=A0 =C2=A0 } >> > >> > =C2=A0 =C2=A0 /** >> > @@ -52,7 +52,7 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 =C2=A0*/ >> > =C2=A0 =C2=A0 public String getExpression() >> > =C2=A0 =C2=A0 { >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0return _expression; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0return expression; >> > =C2=A0 =C2=A0 } >> > >> > =C2=A0 =C2=A0 /** >> > @@ -60,7 +60,7 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 =C2=A0*/ >> > =C2=A0 =C2=A0 public Class getType() >> > =C2=A0 =C2=A0 { >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0return _type; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0return type; >> > =C2=A0 =C2=A0 } >> > >> > =C2=A0 =C2=A0 /** >> > @@ -80,15 +80,15 @@ public class LocalReferenceImpl >> > >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 LocalReferenceImpl that =3D (LocalReferenc= eImpl) o; >> > >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( _expression !=3D null ? !_expression= .equals( that._expression >> ) : that._expression !=3D null ) >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( expression !=3D null ? !expression.e= quals( that.expression ) >> : that.expression !=3D null ) >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return false; >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 } >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( _name !=3D null ? !_name.equals( tha= t._name ) : that._name !=3D >> null ) >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( name !=3D null ? !name.equals( that.= name ) : that.name !=3D >> null ) >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return false; >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 } >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( _type !=3D null ? !_type.equals( tha= t._type ) : that._type !=3D >> null ) >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( type !=3D null ? !type.equals( that.= type ) : that.type !=3D >> null ) >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 { >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return false; >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 } >> > @@ -103,9 +103,9 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 public int hashCode() >> > =C2=A0 =C2=A0 { >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 int result; >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D ( _name !=3D null ? _name.hash= Code() : 0 ); >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D 31 * result + ( _type !=3D nul= l ? _type.hashCode() : 0 ); >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D 31 * result + ( _expression != =3D null ? >> _expression.hashCode() : 0 ); >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D ( name !=3D null ? name.hashCo= de() : 0 ); >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D 31 * result + ( type !=3D null= ? type.hashCode() : 0 ); >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D 31 * result + ( expression != =3D null ? >> expression.hashCode() : 0 ); >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 return result; >> > =C2=A0 =C2=A0 } >> > >> > @@ -115,7 +115,7 @@ public class LocalReferenceImpl >> > =C2=A0 =C2=A0 @Override >> > =C2=A0 =C2=A0 public String toString() >> > =C2=A0 =C2=A0 { >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0return "LocalReferenceImpl[" + "_name=3D'= " + _name + '\'' + '\n' + >> ", _type=3D" + _type + '\n' + ", _expression=3D'" >> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0+ _expression + '\'' + '\n'= + ']'; >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0return "LocalReferenceImpl[" + "_name=3D'= " + name + '\'' + '\n' + >> ", _type=3D" + type + '\n' + ", _expression=3D'" >> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0+ expression + '\'' + '\n' = + ']'; >> > =C2=A0 =C2=A0 } >> > =C2=A0} >> > >> > Modified: >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= OrderedReturn.java >> > URL: >> http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org= /apache/commons/ognl/enhance/OrderedReturn.java?rev=3D1194875&r1=3D1194874&= r2=3D1194875&view=3Ddiff >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= OrderedReturn.java >> (original) >> > +++ >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= OrderedReturn.java >> Sat Oct 29 11:21:20 2011 >> > @@ -19,10 +19,10 @@ package org.apache.commons.ognl.enhance; >> > =C2=A0* under the License. >> > =C2=A0*/ >> > >> > -import org.apache.commons.ognl.Node; >> > >> > =C2=A0/** >> > - * Marks an ognl expression {@link Node} as needing to have the retur= n >> portion of a getter method happen in a specific >> > + * Marks an ognl expression {@link org.apache.commons.ognl.Node} as >> needing to have the return portion of a getter >> > + * method happen in a specific >> > =C2=A0* part of the generated expression vs just having the whole expr= ession >> returned in one chunk. >> > =C2=A0*/ >> > =C2=A0public interface OrderedReturn >> > >> > Modified: >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= package-info.java >> > URL: >> http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org= /apache/commons/ognl/enhance/package-info.java?rev=3D1194875&r1=3D1194874&r= 2=3D1194875&view=3Ddiff >> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= package-info.java >> (original) >> > +++ >> commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/= package-info.java >> Sat Oct 29 11:21:20 2011 >> > @@ -1,6 +1,3 @@ >> > -/** >> > - * Enhanced basic Java components. >> > - */ >> > =C2=A0package org.apache.commons.ognl.enhance; >> > >> > =C2=A0/* >> > @@ -21,3 +18,7 @@ package org.apache.commons.ognl.enhance; >> > =C2=A0* specific language governing permissions and limitations >> > =C2=A0* under the License. >> > =C2=A0*/ >> > + >> > +/* >> > + * Enhanced basic Java components. >> > + */ >> > >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org