commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Grobmeier <grobme...@gmail.com>
Subject Re: [ognl] SVN $ID and @author
Date Sat, 15 Oct 2011 17:01:10 GMT
Guys

On Sat, Oct 15, 2011 at 4:03 PM, Gary Gregory <garydgregory@gmail.com> wrote:
> Can checkstyle be set up to check for author tags?

I think this is going the wrong way.

Gary, Torsten, Phil agreed to remove for DBCP/Pool:
http://markmail.org/thread/ldexerq46xvwxdkh

Here even Sebb had no objections of removing @author tags:
http://bit.ly/oovcjk

Here Emmanmuel and Phil agreed to ask the people to allow removal of
the author tags:
http://markmail.org/message/akemdfo6uf3itcu4

Stefan explains Ant has removed the tags before long while:
http://markmail.org/message/xsmcdu5cpeagshee

Here Sebb explained to me author tags should be removed (in 2008)
http://markmail.org/message/6yb6j37jgqxexmh2

And so on.

It seems people are going forwards and backwards on this. Either we
find a common practise for all Commons components or we should leave
the decision finally up to the maintainers of the code.

Personally I think @author tags is not very community like. I don't
care if my name appears in code or not.

Anyway I am not highly interested in putting these tags into the code
now and in 2008 i removed them.

I have only brought this up b/c i thought i should mention. I have not
had the idea that this will become a discussion between the same
people - again.

OK, now I would be fine with the following procedure:

- removal of all author tags
- pre warn people who are not on the project that their tags are being removed
- remove the author tags of the prewarned people after two more weeks

I would appreciate a standard way in Commons, really.

Cheers
Christian



>
> Gary
>
> On Oct 15, 2011, at 9:53, sebb <sebbaz@gmail.com> wrote:
>
>> On 15 October 2011 14:06, Gary Gregory <garydgregory@gmail.com> wrote:
>>> There was an ASF guideline or suggestion a couple of years ago to use
>>> "Apache Software Foundation" in author tags.
>>
>> Not that I remember.
>>
>> The board recommendation [1] was to not use @author tags at all.
>>
>> [1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt
>> Section 7, subsection F
>>
>> Using @author ASF probably does not go against the spirit of the
>> recommendation; I just don't see the point.
>>
>>> Gary
>>>
>>> On Oct 15, 2011, at 8:17, Emmanuel Bourg <ebourg@apache.org> wrote:
>>>
>>>> -0 on the @author tag since I'm not involved in OGNL.
>>>>
>>>> I find it a bit rude to remove the signature from someone else work. But
>>>> feel free to remove your own name.
>>>>
>>>> Emmanuel Bourg
>>>>
>>>>
>>>> Le 15/10/2011 10:59, Christian Grobmeier a écrit :
>>>>> Again, the old discussion.
>>>>>
>>>>> OGNL has @author tags. I do not like them. Who wants to keep them? I
>>>>> prefer a developers section in the pom and of course there is svn
>>>>> history.
>>>>>
>>>>> In addition:
>>>>>  * $Id: ASTAdd.java 1183232 2011-10-14 07:40:32Z grobmeier $
>>>>>
>>>>> This line must not be the first of the license header, otherwise
>>>>> checkstyle is crying. In addition I have never understood the sense of
>>>>> that line. I am +1 for removing it too (svn history does all i need).
>>>>>
>>>>> If we keep it, we need to move it on class level docs.
>>>>>
>>>>> OK, let the rumble begin... your opinions gents!
>>>>>
>>>>> CHeers
>>>>> Christian
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
http://www.grobmeier.de

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message