commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [ognl] SVN $ID and @author
Date Sat, 15 Oct 2011 09:16:47 GMT
On 15 October 2011 09:59, Christian Grobmeier <grobmeier@gmail.com> wrote:
> Again, the old discussion.
>
> OGNL has @author tags. I do not like them. Who wants to keep them? I
> prefer a developers section in the pom and of course there is svn
> history.
>
> In addition:
>  * $Id: ASTAdd.java 1183232 2011-10-14 07:40:32Z grobmeier $
>
> This line must not be the first of the license header, otherwise
> checkstyle is crying. In addition I have never understood the sense of
> that line. I am +1 for removing it too (svn history does all i need).

Can be useful, if one comes across a source file in isolation from SVN.
For example, in source archives.
Also as comments in generated HTML files..

It's not harmful (if added in the correct location) so I'm +1 for keeping it.

> If we keep it, we need to move it on class level docs.

Or at least below the AL header.

> OK, let the rumble begin... your opinions gents!
>
> CHeers
> Christian
>
> --
> http://www.grobmeier.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message