On 2 October 2011 19:57, <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Sun Oct 2 18:57:51 2011
> New Revision: 1178220
>
> URL: http://svn.apache.org/viewvc?rev=1178220&view=rev
> Log:
> Update to JUnit 4.10 from 3.8.1. Use includeantruntime="false" for repeatable builds.
>
> Modified:
> commons/proper/io/trunk/build.xml
>
> Modified: commons/proper/io/trunk/build.xml
> URL: http://svn.apache.org/viewvc/commons/proper/io/trunk/build.xml?rev=1178220&r1=1178219&r2=1178220&view=diff
> ==============================================================================
> --- commons/proper/io/trunk/build.xml (original)
> +++ commons/proper/io/trunk/build.xml Sun Oct 2 18:57:51 2011
> @@ -153,13 +153,14 @@
>
> <target name="compile" depends="init" description="Compile">
>
> - <javac srcdir="${source.home}"
> + <javac srcdir="${source.home}"
> destdir="${build.home}/classes"
> - source="${compile.source}"
> - target="${compile.target}"
> - debug="${compile.debug}"
> - deprecation="${compile.deprecation}"
> - optimize="${compile.optimize}">
> + source="${compile.source}"
> + target="${compile.target}"
> + debug="${compile.debug}"
> + deprecation="${compile.deprecation}"
> + optimize="${compile.optimize}"
> + includeantruntime="false">
> <classpath refid="compile.classpath"/>
> </javac>
> </target>
> @@ -173,7 +174,8 @@
> destdir="${build.home}/test-classes"
> debug="${compile.debug}"
> deprecation="${compile.deprecation}"
> - optimize="${compile.optimize}">
> + optimize="${compile.optimize}"
> + includeantruntime="false">
> <classpath refid="test.classpath"/>
> </javac>
> </target>
> @@ -335,7 +337,7 @@
> <mkdir dir="${download.lib.dir}" />
> <get dest="${download.lib.dir}/junit.jar"
> usetimestamp="true" ignoreerrors="true"
> - src="http://www.ibiblio.org/maven/junit/jars/junit-3.8.1.jar"/>
> + src="https://github.com/downloads/KentBeck/junit/junit-4.10.jar"/>
-1
That does not fix the problem of the stale JUnit version - it just
postpones it until the next version change.
Which is what caused the original issue.
The junit version should be defined - once - as a property, and used
everywhere else by referencing the property.
There should probably be a check of the jar MD5 too, but that is a
separate issue.
> </target>
>
> </project>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
|