commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons-DbUtils 1.4 based on RC2
Date Wed, 12 Oct 2011 14:28:30 GMT
On Wed, Oct 12, 2011 at 10:25 AM, Simone Tripodi
<simonetripodi@apache.org>wrote:

> Hi Gary!
> It makes a lot of sense, thanks for reviewing!
>

Good luck Simo. I look forward to a shiny new RC :)

Gary


> All the best, have a nice day!
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Wed, Oct 12, 2011 at 4:22 PM, Gary Gregory <garydgregory@gmail.com>
> wrote:
> > There are some PMD violations too that could be addressed as well.
> >
> > Gary
> >
> > On Wed, Oct 12, 2011 at 10:15 AM, Gary Gregory <garydgregory@gmail.com
> >wrote:
> >
> >> Hi Simo,
> >>
> >> Thank you for cutting the RC.
> >>
> >> -1
> >>
> >>    - Clirr reports 2 errors.
> >>    Accessibility of method 'public DbUtils()' has been decreased from
> >>    public to private.
> >>    This is a no-go for a minor release unless we want to make an
> >>    exception.
> >>
> >>    - RAT reports one unapproved license.
> >>    I know it's a one-liner but, either fix it or configure RAT
> otherwise.
> >>    Either way, something should be done IMO. Seeing "Unapproved
> licenses" on
> >>    the site does not inspire confidence.
> >>
> >>    - Checktyle reports 14 errors.
> >>    These all look easy to fix.
> >>
> >> The following is not part of the -1 but still worth considering for this
> >> release.
> >>
> >> As reported by Cobertura:
> >>
> >> - KeyedHandler(RowProcessor convert) is not tested. Testing this will
> bring
> >> the containing package coverage to 100%.
> >> - Most of ResultSetIterator is not tested.
> >> - DbUtils only gets 12% test coverage.
> >> - A lot of BeanProcessor is not covered.
> >>
> >> Gary
> >>
> >>
> >> On Wed, Oct 12, 2011 at 9:07 AM, Simone Tripodi <
> simonetripodi@apache.org>wrote:
> >>
> >>> Hi all guys,
> >>> I call for a vote to release apache commons-dbutils-1.4 based on RC2.
> >>> Many thanks in advance for reviewing, have a nice day!
> >>> All the best,
> >>> Simo
> >>>
> >>> Tag:
> >>>
> >>>
> >>>
> https://svn.apache.org/repos/asf/commons/proper/dbutils/tags/DBUTILS_1_4_RC2
> >>>
> >>> Site:
> >>>
> >>>    http://people.apache.org/builds/commons/dbutils/1.4/RC2/site/
> >>>
> >>> Binaries:
> >>>
> >>>    http://people.apache.org/builds/commons/dbutils/1.4/RC2/binaries/
> >>>
> >>> Maven Artifacts
> >>>
> >>>    http://people.apache.org/builds/commons/dbutils/1.4/RC2/staged/
> >>>
> >>> [ ] +1 release it
> >>> [ ] +0 go ahead I don't care
> >>> [ ] -1 no, do not release it because
> >>>
> >>> http://people.apache.org/~simonetripodi/
> >>> http://simonetripodi.livejournal.com/
> >>> http://twitter.com/simonetripodi
> >>> http://www.99soft.org/
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >>
> >>
> >> --
> >> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> >> Blog: http://garygregory.wordpress.com
> >> Home: http://garygregory.com/
> >> Tweet! http://twitter.com/GaryGregory
> >>
> >
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message