commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [ognl] Codestyle
Date Mon, 10 Oct 2011 01:57:45 GMT
On Oct 9, 2011, at 20:53, sebb <sebbaz@gmail.com> wrote:

> On 10 October 2011 01:22, Gary Gregory <garydgregory@gmail.com> wrote:
>> On Sun, Oct 9, 2011 at 7:57 PM, sebb <sebbaz@gmail.com> wrote:
>>
>>> On 9 October 2011 14:30, Gary Gregory <garydgregory@gmail.com> wrote:
>>>> On Sun, Oct 9, 2011 at 7:53 AM, Christian Grobmeier <grobmeier@gmail.com>
>>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Checkstyle shows me more or less that we should go conform the
Sun
>>>>>>> standards. I would love this, but want to make sure we have agreed
on
>>>>>>> it. Because it would need a good bunch of bracket-moving
>>>>
>>>> I'm +1 on that. The change can be done automatically with most IDEs.
>>>> This should not be any "work".
>>>
>>> Except for the people who review commits ...
>>>
>>
>> Commit comments are good for this: "Automatic formatting by
>> Eclipse/NetBeans/YourIDE following convention foo"
>
> Of course, but automated changes are not guaranteed error-free.
> And it's easy to overlook some other change that was accidentally
> committed at the same time.
>
> If the code is currently self consistent, why change it?

Self consistency is great. People who write the code should have the
most say and I'm not participating here so I'll accept this
community's choice. That said, it would be really nice to have more
consistency within commons itself. That might be a pipe dream but
there you have it :)


>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message