Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0370B75E9 for ; Thu, 8 Sep 2011 06:43:19 +0000 (UTC) Received: (qmail 84795 invoked by uid 500); 8 Sep 2011 06:43:17 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 84258 invoked by uid 500); 8 Sep 2011 06:43:08 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 83153 invoked by uid 99); 8 Sep 2011 06:43:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2011 06:43:00 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates 209.85.216.41 as permitted sender) Received: from [209.85.216.41] (HELO mail-qw0-f41.google.com) (209.85.216.41) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2011 06:42:52 +0000 Received: by qwa26 with SMTP id 26so349788qwa.0 for ; Wed, 07 Sep 2011 23:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=rrsfBQsirCnte4pii2oZSEFLmNYW5IyVM+WQExGOg+o=; b=u5PkyeinK9CpkJaLoDBdaZdk4iLQXJ5miMovk6RZJhKZe/4S3G0QBqpFHFz4/xxOgP gXARys9PvFRNadUyqiCGHcgCOr2lPPMKIaqSAk3XpKasOg8+GN34R1AW/r9syjj8chXS moVOqhYqH0wV5mlJRKyRikg+tyS92w77MiWgw= MIME-Version: 1.0 Received: by 10.229.21.20 with SMTP id h20mr204051qcb.265.1315464151534; Wed, 07 Sep 2011 23:42:31 -0700 (PDT) Received: by 10.229.248.144 with HTTP; Wed, 7 Sep 2011 23:42:31 -0700 (PDT) In-Reply-To: <20110906151647.CB0BA2388900@eris.apache.org> References: <20110906151647.CB0BA2388900@eris.apache.org> Date: Wed, 7 Sep 2011 23:42:31 -0700 Message-ID: Subject: Re: svn commit: r1165701 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java From: Henri Yandell To: dev@commons.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Sep 6, 2011 at 8:16 AM, wrote: > Author: sebb > Date: Tue Sep =A06 15:16:47 2011 > New Revision: 1165701 > > URL: http://svn.apache.org/viewvc?rev=3D1165701&view=3Drev > Log: > LANG-744 StringUtils throws java.security.AccessControlException on Googl= e App Engine > Change static code to catch and save Exception; only report failure if no= method is available > > Modified: > =A0 =A0commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/S= tringUtils.java > > Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang= 3/StringUtils.java > URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java= /org/apache/commons/lang3/StringUtils.java?rev=3D1165701&r1=3D1165700&r2=3D= 1165701&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Stri= ngUtils.java (original) > +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Stri= ngUtils.java Tue Sep =A06 15:16:47 2011 > @@ -630,13 +630,14 @@ public class StringUtils { > =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 try { > =A0 =A0 =A0 =A0 =A0 =A0 String result =3D null; > - =A0 =A0 =A0 =A0 =A0 =A0if (java6Available) { > + =A0 =A0 =A0 =A0 =A0 =A0if (java6NormalizeMethod !=3D null) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 result =3D removeAccentsJava6(input); > - =A0 =A0 =A0 =A0 =A0 =A0} else if (sunAvailable) { > + =A0 =A0 =A0 =A0 =A0 =A0} else if (sunDecomposeMethod !=3D null) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 result =3D removeAccentsSUN(input); > =A0 =A0 =A0 =A0 =A0 =A0 } else { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 throw new UnsupportedOperationException( > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"The stripAccents(CharSequence) = method requires at least Java 1.6 or a Sun JVM"); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"The stripAccents(CharSequence) = method requires at least Java 1.6 or a Sun JVM", > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0new UnsupportedOperationExceptio= n(java6Exception)); Was it intended to have the same Exception twice? UOE in UOE? Hen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org