Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebastien.brisard@gmail.com
 designates 209.85.212.49 as permitted sender)
MIME-Version: 1.0
Sender: sebastien.brisard@gmail.com
In-Reply-To: 
 <CAJwFCa1nBi-j+UBZsPc_ra9fU4=zzna25e+jT8LG=rHvnRrF1Q@mail.gmail.com>
References: 
 <CAGRH7Hq15zR9+YUWqFYCQQ0ZGFyvCDMMk4ru3Nmduua5pBOriQ@mail.gmail.com>
	<4E6919E1.3010905@free.fr>
	<CAGRH7HqYVkRkHTjGQA391GADknoipjHiPz9MA38TcpqcfTAzVQ@mail.gmail.com>
	<CAJwFCa1nBi-j+UBZsPc_ra9fU4=zzna25e+jT8LG=rHvnRrF1Q@mail.gmail.com>
Date: Fri, 9 Sep 2011 04:05:17 +0200
Message-ID: 
 <CAGRH7HoKQ=3bS6RJ-LsfqfQEyGeitSUhPuEKqy_oq6oQS=s_uQ@mail.gmail.com>
Subject: Re: [math] use the more general super-type RealMatrix in place of
 Array2DRowRealMatrix in package ode?
From: =?ISO-8859-1?Q?S=E9bastien_Brisard?= <sebastien.brisard@m4x.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Sorry Ted, I was not very clear in my explanations.
solve does return a RealMatrix. Internally, it builds BlockRealMatrix, thou=
gh.
The issue is that Luc needs the underlying double[][] array in this
ODE application. This you could easily get if the returned matrix were
a Array2DRowRealMatrix, and you could have something along the lines
{code}
RealMatrix x =3D decomposition.getSolver().solve(new
Array2DRowRealMatrix(b, false));
if (x instanceof Array2DRowRealMatrix){
    return x.getDataRef();
} else {
    return new Array2DRowRealMatrix(x.getData(), false);
}
{code}
but this hack is of no use here, since it turns out that the
decomposition solver being used here *always* returns a
BlockRealMatrix (as an Array2DRealMatrix). So basically, deep copy of
x through x.getData() will *always* occur. That's what is worrying me.
I hope I do make my point, now.
S=E9bastien

2011/9/9 Ted Dunning <ted.dunning@gmail.com>:
> Why doesn't solve just return a RealMatrix? =A0Why does it insist on retu=
rning
> an Array2DRowRealMatrix?
>
> Does the user really care?
>
> 2011/9/8 S=E9bastien Brisard <sebastien.brisard@m4x.org>
>
>> Hi Luc,
>> thanks for your detailed explanations attached to the MATH-659. I'm
>> worried about the changes I have applied to the code, now. Here is
>> what I've done. I've replaced the following line
>> {code}
>> return new Array2DRowRealMatrix(decomposition.getSolver().solve(b), fals=
e);
>> {code}
>> with
>> {code}
>> RealMatrix x =3D decomposition.getSolver().solve(new
>> Array2DRowRealMatrix(b, false));
>> return new Array2DRowRealMatrix(x.getData(), false);
>> {code}
>>
>> decomposition is in fact an instance of QRDecompositionImpl.Solver,
>> whose method solve(RealMatrix) returns a BlockRealMatrix, not an
>> Array2DRowRealMatrix, hence the ugly last line. This code seems to be
>> correct (unit tests still pass), but I'm worried about the efficiency,
>> especially if initializeHighOrderDerivatives is called very often.
>> What do you think should be done?
>>
>> Best regards,
>> S=E9bastien
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org