Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of simone.tripodi@gmail.com
 designates 209.85.161.175 as permitted sender)
MIME-Version: 1.0
Sender: simone.tripodi@gmail.com
In-Reply-To: 
 <CAOGo0VbSCawonkdh3UMvJOpEGqyot6__9sS1rnS96GHC3RkKsQ@mail.gmail.com>
References: <20110914193437.618732388AF0@eris.apache.org>
	<CAOGo0VbSCawonkdh3UMvJOpEGqyot6__9sS1rnS96GHC3RkKsQ@mail.gmail.com>
Date: Wed, 14 Sep 2011 22:06:44 +0200
Message-ID: 
 <CAAqLGLMJgEAQEm0pFXJNmrJC3eGTs1PtQPPnLxEbGOhiLjKJCg@mail.gmail.com>
Subject: Re: svn commit: r1170805 -
 /commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.java
From: Simone Tripodi <simonetripodi@apache.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

we already discussed about it, and choose the option to let users
extend the classes for 2 reasons:
 - be reused inside IoC/DI containers that create dynamic proxies
 - specialize classes with generic types (class
MyTransformedBinaryProcedure extends TransformedBinaryProcedure<MyL,
MyR, MyT>)

yes, checkstyle complains about those violations[1]

anyways, every suggestion is more than welcome!
Simo

[1] http://commons.apache.org/sandbox/functor/checkstyle.html

http://people.apache.org/~simonetripodi/
http://www.99soft.org/


On Wed, Sep 14, 2011 at 9:42 PM, sebb <sebbaz@gmail.com> wrote:
> On 14 September 2011 20:34, =C2=A0<simonetripodi@apache.org> wrote:
>> Author: simonetripodi
>> Date: Wed Sep 14 19:34:37 2011
>> New Revision: 1170805
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1170805&view=3Drev
>> Log:
>> fixed checkstyle violation: Method 'hashCode' is not designed for extens=
ion - needs to be abstract, final or empty
>
> Is the class intended for extension?
> If so, and you add fields, you won't be able to override hashCode to
> take account of them.
> If not, just make the class final.
>
> Are you sure that the Checkstyle complaint is valid here?
>
>> Modified:
>> =C2=A0 =C2=A0commons/sandbox/functor/trunk/src/main/java/org/apache/comm=
ons/functor/core/composite/TransformedBinaryProcedure.java
>>
>> Modified: commons/sandbox/functor/trunk/src/main/java/org/apache/commons=
/functor/core/composite/TransformedBinaryProcedure.java
>> URL: http://svn.apache.org/viewvc/commons/sandbox/functor/trunk/src/main=
/java/org/apache/commons/functor/core/composite/TransformedBinaryProcedure.=
java?rev=3D1170805&r1=3D1170804&r2=3D1170805&view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- commons/sandbox/functor/trunk/src/main/java/org/apache/commons/funct=
or/core/composite/TransformedBinaryProcedure.java (original)
>> +++ commons/sandbox/functor/trunk/src/main/java/org/apache/commons/funct=
or/core/composite/TransformedBinaryProcedure.java Wed Sep 14 19:34:37 2011
>> @@ -107,7 +107,7 @@ public class TransformedBinaryProcedure<
>> =C2=A0 =C2=A0 =C2=A0* {@inheritDoc}
>> =C2=A0 =C2=A0 =C2=A0*/
>> =C2=A0 =C2=A0 @Override
>> - =C2=A0 =C2=A0public int hashCode() {
>> + =C2=A0 =C2=A0public final int hashCode() {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 int result =3D "TransformedBinaryProcedure".=
hashCode();
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 result <<=3D 2;
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 result |=3D helper.procedure.hashCode();
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org