Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of phil.steitz@gmail.com
 designates 209.85.213.171 as permitted sender)
Message-ID: <4E6245CC.3090902@gmail.com>
Date: Sat, 03 Sep 2011 08:20:44 -0700
From: Phil Steitz <phil.steitz@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: svn commit: r1164625 -
 /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
References: <20110902164859.EA9D12388A02@eris.apache.org>
 <4E61B524.7080104@gmail.com>
 <e5aa2d75-0985-4664-9f9d-7dfda94ef16c@email.android.com>
In-Reply-To: <e5aa2d75-0985-4664-9f9d-7dfda94ef16c@email.android.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 9/3/11 1:07 AM, markt@apache.org wrote:
> Phil Steitz <phil.steitz@gmail.com> wrote:
>
>> On 9/2/11 9:48 AM, markt@apache.org wrote:
>>> Author: markt
>>> Date: Fri Sep  2 16:48:59 2011
>>> New Revision: 1164625
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1164625&view=rev
>>> Log:
>>> Fix typo
>> I guess you meant, remove trailing spaces or tabs or something?
>>
>> Phil
> Nope. What I typed is what I meant.

Sorry, blind last night :)

Phil
>
> Mark
>
>>> Modified:
>>>    
>> commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
>>> Modified:
>> commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
>>> URL:
>> http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1164625&r1=1164624&r2=1164625&view=diff
>> ==============================================================================
>>> ---
>> commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
>> (original)
>>> +++
>> commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
>> Fri Sep  2 16:48:59 2011
>>> @@ -1329,21 +1329,21 @@ public class GenericKeyedObjectPool<K,T>
>>>          return p;
>>>      }
>>>  
>>> -    private boolean destroy(K key, PooledObject<T> toDestory,
>> boolean always)
>>> +    private boolean destroy(K key, PooledObject<T> toDestroy,
>> boolean always)
>>>              throws Exception {
>>>          
>>>          register(key);
>>> -        toDestory.invalidate();
>>> +        toDestroy.invalidate();
>>>  
>>>          try {
>>>              ObjectDeque<T> objectDeque = poolMap.get(key);
>>> -            boolean isIdle =
>> objectDeque.getIdleObjects().remove(toDestory);
>>> +            boolean isIdle =
>> objectDeque.getIdleObjects().remove(toDestroy);
>>>              
>>>              if (isIdle || always) {
>>> -               
>> objectDeque.getAllObjects().remove(toDestory.getObject());
>>> +               
>> objectDeque.getAllObjects().remove(toDestroy.getObject());
>>>          
>>>                  try {
>>> -                    _factory.destroyObject(key,
>> toDestory.getObject());
>>> +                    _factory.destroyObject(key,
>> toDestroy.getObject());
>>>                  } finally {
>>>                      objectDeque.getCreateCount().decrementAndGet();
>>>                      destroyedCount.incrementAndGet();
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org