Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Thu, 22 Sep 2011 16:41:02 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: [Math] MathUtils.checkOrder
Message-ID: <20110922144102.GN2590@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: 
 <CACMPRi2WF0bWd=D5dq2b8G-3z+-hCtXCLjAsxWg2EbcjpnvKCA@mail.gmail.com>
 <CACMPRi0+vCtRGNvD6pgwgt8Z-Ni0rVrkxx30M3X=6yNTTrnHhg@mail.gmail.com>
 <20110921225619.GC17021@dusk.harfang.homelinux.org>
 <CACMPRi0acx8Sw53n0Rhdc7Dg6Cn8ES+tyuHVF6VBqf2fCH==bA@mail.gmail.com>
 <4E7A8448.2010909@gmail.com>
 <CACMPRi3QKvgL9xVUhwnp4zp1VG8Nv+G4b9986vp-VGk9cbfrAw@mail.gmail.com>
 <4E7A8EF0.3040009@gmail.com>
 <CACMPRi3XGuar+83qEf_FcqS1xrrCkuce87JOBNr63KAMG+M-Rw@mail.gmail.com>
 <20110922133908.GM2590@dusk.harfang.homelinux.org>
 <CACMPRi2jBpLLSEgrSb-t17CVq3Avk52Syi-+D--Bpa898QKuxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CACMPRi2jBpLLSEgrSb-t17CVq3Avk52Syi-+D--Bpa898QKuxA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DCC-scarlet.be-Metrics: sif 20001; Body=1 Fuz1=1 Fuz2=1
X-Virus-Scanned: clamav-milter 0.97.1-exp at sif
X-Virus-Status: Clean
X-Virus-Checked: Checked by ClamAV on apache.org

On Thu, Sep 22, 2011 at 08:58:19AM -0500, Greg Sterijevski wrote:
> I agree with your assessment that having almost identical methods is a pain.
> However, without doing this I need to return a very complicated set of
> information from isMonotone to be able to construct the exception.

Yes, this would be ugly indeed.

> As for catching the exception, I was under the impression that CM code never
> catches exceptions, you propagate them upwards on the call tree.

I think that you refer to not catching user-generated exceptions.

Here the example was given that the caller (a CM method) could decide which
exception to throw whenever "isMonotone" returns false.
My preference is to always throw the same exception (i.e. an instance of
"NonMonoton(e/ic/ous)SequenceException"). However if there is a case where
the caller would want to throw another one, I'd thought that it would be
clearer to catch and rethrow. Well, that's ugly too; in the end, I think we
should stick to "NonMonoton(e/ic/ous)SequenceException". :-)

> In thinking about this, maybe you are correct. The exception could be
> pruned. I am reticent to do this because it looks like exceptions and
> exception reporting are  sore subjects on for the developers on this
> project?

Yes. It used to always be "We want all the details". But then there is also
the recent example of "NotPositiveDefiniteMatrixException" where the
"threshold" is considered too much detail...


Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org