Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 7 Sep 2011 14:46:18 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: svn commit: r1166099 -
 /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/LUDecompositionImpl.java
Message-ID: <20110907124618.GU2590@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <20110907103449.A98B92388A6E@eris.apache.org>
 <4E6749E9.9010506@apache.org>
 <20110907114938.GT2590@dusk.harfang.homelinux.org>
 <4E676083.1090106@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E676083.1090106@apache.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DCC-scarlet.be-Metrics: sif 20001; Body=1 Fuz1=1 Fuz2=1
X-Virus-Scanned: clamav-milter 0.97.1-exp at sif
X-Virus-Status: Clean

On Wed, Sep 07, 2011 at 01:16:03PM +0100, Mark Thomas wrote:
> On 07/09/2011 12:49, Gilles Sadowski wrote:
> > On Wed, Sep 07, 2011 at 11:39:37AM +0100, Mark Thomas wrote:
> >> On 07/09/2011 11:34, erans@apache.org wrote:
> >>> Author: erans
> >>> Date: Wed Sep  7 10:34:49 2011
> >>> New Revision: 1166099
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1166099&view=rev
> >>> Log:
> >>> Added "final".
> >>> Moved declaration of "sum" where it is used.
> >>
> >> You might want to re-consider that. I suspect sum was declared outside
> >> of the inner loops to save allocating memory for a new double on every
> >> iteration of the loop. It may be worth moving the declaration outside
> >> the outer loop too.
> > 
> > Reducing scope makes for clearer code and can lead to _more_ optimized code.
> 
> Cleaner code, certainly.
> 
> As far as optimisation goes I'm not so sure with a primitive. On further
> research it looks like the performance should be identical. For an
> "interesting" discussion on what exactly is going on I found this:
> http://www.javalobby.org/java/forums/t16730.html?start=0

So:
 - Cleaner code: Yes
 - Faster code: Maybe
 - Higher memory usage: No

Do we agree that the change is fine?


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org