Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 7 Sep 2011 13:49:38 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: svn commit: r1166099 -
 /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/LUDecompositionImpl.java
Message-ID: <20110907114938.GT2590@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <20110907103449.A98B92388A6E@eris.apache.org>
 <4E6749E9.9010506@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E6749E9.9010506@apache.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DCC-scarlet.be-Metrics: hel 20002; Body=1 Fuz1=1 Fuz2=1
X-Virus-Scanned: clamav-milter 0.97.1-exp at hel
X-Virus-Status: Clean

On Wed, Sep 07, 2011 at 11:39:37AM +0100, Mark Thomas wrote:
> On 07/09/2011 11:34, erans@apache.org wrote:
> > Author: erans
> > Date: Wed Sep  7 10:34:49 2011
> > New Revision: 1166099
> > 
> > URL: http://svn.apache.org/viewvc?rev=1166099&view=rev
> > Log:
> > Added "final".
> > Moved declaration of "sum" where it is used.
> 
> You might want to re-consider that. I suspect sum was declared outside
> of the inner loops to save allocating memory for a new double on every
> iteration of the loop. It may be worth moving the declaration outside
> the outer loop too.

Reducing scope makes for clearer code and can lead to _more_ optimized code.


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org