Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Fri, 2 Sep 2011 19:07:47 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: svn commit: r1164615 -
 /commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java
Message-ID: <20110902170747.GH19625@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <20110902163441.68AB523889E3@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20110902163441.68AB523889E3@eris.apache.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-DCC-scarlet.be-Metrics: hel 20001; Body=1 Fuz1=1 Fuz2=1
X-Virus-Scanned: clamav-milter 0.97.1-exp at hel
X-Virus-Status: Clean
X-Virus-Checked: Checked by ClamAV on apache.org

Hi S�bastien.

>  
>  /**
>   * Gauss-Newton least-squares solver.
> @@ -146,8 +148,13 @@ public class GaussNewtonOptimizer extend
>                  DecompositionSolver solver = useLU ?
>                          new LUDecompositionImpl(mA).getSolver() :
>                          new QRDecompositionImpl(mA).getSolver();
> -                final double[] dX = solver.solve(b);
> -
> +                final RealVector dummy = solver.solve(new ArrayRealVector(b, false));
> +                final double[] dX;
> +                if (dummy instanceof ArrayRealVector){
> +                    dX = ((ArrayRealVector) dummy).getDataRef();
> +                }else{
> +                    dX = dummy.getData();
> +                }

In my opinion, the hypothetical efficiency gain is not worth the convoluted
code so:
---
  final double[] dX = solver.solve(new ArrayRealVector(b, false)).toArray();
---

Also, next time, when you'll really need a curly bracket ;-), please insert
a space character before it, and around keywords too:
---
if (ok) {
  // ...
} else {
  // ...
}
---

Sorry to be picky and thank you,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org