commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: [parent] adding buildnumber in the manifest entries
Date Fri, 09 Sep 2011 20:50:18 GMT
2011/9/9 sebb <sebbaz@gmail.com>:
> On 9 September 2011 14:53, Olivier Lamy <olamy@apache.org> wrote:
>> Maybe possible to add something for folks using git svn.
>>
>> An other profile activated if .git is present and change the scm
>> provider used for buildnumber (see [1] ) :
>
> Just wondering - why is svnjava not the default?

the svnkit license issue has never been solved or at least I didn't
get any real response.
Can a ASF project be dependant on svnkit even if the svnkit binary is
not distributed with the asf binaries but dependency is resolved from
maven repository ....
So I have moved the svnjava provider is in googlecode then in
apacheextras. (http://code.google.com/a/apache-extras.org/p/maven-scm-provider-svnjava/)


> It seems to work just as well, and does not rely on command-line access to SVN.
I definitely prefer this too !
>
> Also, there's a problem with using a profile - if the plugin does not
> run, then the buildNumber property does not get set, so the revision
> text shows as "rnull" which is not user-friendly.
>
> I tried defining the property in the POM so it has a default, but then
> the plugin does not override it, and creating the property allows the
> user to override it on the command-line, which seems a bad idea.
>
> There's probably a way to fix this, but the plugin seems to run OK
> regardless of whether SVN is present or it is run in a workspace, so
> it's probably not necessary to skip the execution.
>
>> providerImplementations : <svn>git</svn>  (hackhish maybe and not tested
:-) ).
>>
>> The git scm provider use : git rev-parse --verify HEAD .
>> Which produce a result even with git svn.
>>
>> --
>> Olivier
>>
>> [1] http://mojo.codehaus.org/buildnumber-maven-plugin/using-svnjava.html
>>
>> 2011/9/9 Simone Tripodi <simonetripodi@apache.org>:
>>> OK,
>>> I also did a little experiment following Olivier's suggestions and it worked.
>>> Just the time to revert to the initial form so I can commit and you
>>> all can see how it works and play with it.
>>> TIA!
>>> Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://www.99soft.org/
>>>
>>>
>>>
>>> On Fri, Sep 9, 2011 at 3:41 PM, sebb <sebbaz@gmail.com> wrote:
>>>> On 9 September 2011 14:28, Simone Tripodi <simonetripodi@apache.org>
wrote:
>>>>> @Seb: revision-unknown sounds better indeed
>>>>>
>>>>> @Olivier: you are always super :) going to move the stuff to the profile
>>>>
>>>> Not sure I agree that the profile is a good idea; it only works for
>>>> Subversion (the plugin supports other CMS) and the test relies on an
>>>> implementation detail of SVN.
>>>>
>>>> Unless the plugin causes issues for non-workspace builds, I think it's
>>>> better if it is always active.
>>>> Alternatively, it could be in a profile that is active by default; the
>>>> profile could then be disabled if it turns out later that there are
>>>> edge cases that fail.
>>>>
>>>>> WDYT if I commit that stuff and reverting if starts creating issues?
>>>>> we have Olivier in any way ;)
>>>>
>>>> +1, we need to be able to try it easily.
>>>>
>>>>> Simo
>>>>>
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://www.99soft.org/
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Sep 9, 2011 at 3:10 PM, Olivier Lamy <olamy@apache.org>
wrote:
>>>>>> why not having a profile for that ? (folks using git svn or building
>>>>>> from the src distrib).
>>>>>>
>>>>>>    <profile>
>>>>>>      <id>buildnumber</id>
>>>>>>      <activation>
>>>>>>        <file>
>>>>>>          <exists>.svn</exists>
>>>>>>        </file>
>>>>>>      </activation>
>>>>>>      <build>
>>>>>>        <plugins>
>>>>>>          <plugin>
>>>>>>            <groupId>org.codehaus.mojo</groupId>
>>>>>>            <artifactId>buildnumber-maven-plugin</artifactId>
>>>>>>            blabla setup of the plugin
>>>>>>          </plugin>
>>>>>>        </plugins>
>>>>>>      </build>
>>>>>>    </profile>
>>>>>>
>>>>>> 2011/9/9 Simone Tripodi <simonetripodi@apache.org>:
>>>>>>> The plugin supports the offline mode, I configured it to add
>>>>>>>
>>>>>>>    Implementation-Build: local-dev; 2011-09-09 09:17:22+0200
>>>>>>>
>>>>>>> instead of
>>>>>>>
>>>>>>>    Implementation-Build: r1166864; 2011-09-09 09:17:22+0200
>>>>>>>
>>>>>>> WDYT?
>>>>>>> Simo
>>>>>>>
>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>> http://www.99soft.org/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Sep 9, 2011 at 2:59 PM, sebb <sebbaz@gmail.com>
wrote:
>>>>>>>> On 9 September 2011 08:35, Simone Tripodi <simonetripodi@apache.org>
wrote:
>>>>>>>>> Good morning guys,
>>>>>>>>> I just did an experiment on my local checkout of the
parent pom,
>>>>>>>>> adding the buildnumber plugin, in order to have a new
>>>>>>>>> `Implementation-Build` manifest entry in the jars, where
reported the
>>>>>>>>> revision number and the timestamp.
>>>>>>>>> I applied locally on [chain] and got:
>>>>>>>>>
>>>>>>>>>    Implementation-Build: r1166864; 2011-09-09 09:17:22+0200
>>>>>>>>>
>>>>>>>>> I'd like to commit it if no one has objections, if needed
I can fill
>>>>>>>>> an Issue and attach the patch.
>>>>>>>>> Please let me know, thanks in advance!
>>>>>>>>
>>>>>>>> What happens if you try running a build outside the SVN workspace?
>>>>>>>>
>>>>>>>> e.g. a user may just download a source archive, and try building
from that.
>>>>>>>>
>>>>>>>>> Have a nice day,
>>>>>>>>> Simo
>>>>>>>>>
>>>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>>>> http://www.99soft.org/
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Olivier Lamy
>>>>>> Talend : http://talend.com
>>>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>>
>> --
>> Olivier Lamy
>> Talend : http://talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message