commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject [io] LockableFileWriter.close() ignores exceptional return value of java.io.File.delete()
Date Wed, 07 Sep 2011 12:26:36 GMT
Should LockableFileWriter.close() be changed from:

    public void close() throws IOException {
        try {
            out.close();
        } finally {
            lockFile.delete();
        }

to:

    public boolean close() throws IOException {
        try {
            out.close();
        } finally {
            return lockFile.delete();
        }

?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: http://s.apache.org/rl
Spring Batch in Action: http://s.apache.org/HOq
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message