commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [Math] MathUtils.checkOrder
Date Thu, 22 Sep 2011 09:02:19 GMT
On Wed, Sep 21, 2011 at 06:27:12PM -0700, Phil Steitz wrote:
> On 9/21/11 6:11 PM, Greg Sterijevski wrote:
> > One more question, there is a boolean argument called 'abort', what sense
> > does it make to keep checking an array given you have found one observation
> > which violates monotonicity? I think abort is redundant and could be
> > eliminated. Thoughts?
> 
> Looks like what is there now actually combines "isMonotone" and
> "checkMonotone."  It returns a boolean and the abort parameter tells
> it whether or not to throw instead of returning false.  I would see
> a better separation of concerns to separate the two methods and let
> the caller decide which one to use and whether or not (and what) to
> throw when using isMonotone.
> 
> You are right that the impl looks like it could be improved to stop
> checking when it has found a violation.

Yes, sorry for that. That was indeed the intention.

Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message