commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1167252 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math: exception/util/LocalizedFormats.java linear/CholeskyDecompositionImpl.java linear/NonPositiveDefiniteMatrixException.java
Date Fri, 09 Sep 2011 20:59:22 GMT
> > [...]
> >      ALPHA("alpha"), /* keep */
> >      BETA("beta"), /* keep */
> >      NOT_POSITIVE_COLUMNDIMENSION("invalid column dimension: {0} (must be positive)"),
> > -    NOT_POSITIVE_DEFINITE_MATRIX("not positive definite matrix"),
> > -    NON_POSITIVE_DEFINITE_MATRIX("not positive definite matrix: diagonal element
at ({1},{1}) is smaller than {2} ({0})"), /* keep */
> > +    NOT_POSITIVE_DEFINITE_MATRIX("not positive definite matrix"), /* keep */
> 
> I would say we can toss the one above - it really doesn't add any
> information.

I don't understand. This is the simple message about the precondition
failure, valid in all cases.

> > +    NON_POSITIVE_DEFINITE_MATRIX("not positive definite matrix: diagonal element
at ({1},{1}) is smaller than {2} ({0})"),
> >      NON_POSITIVE_DEFINITE_LINEAR_OPERATOR("non positive definite linear operator"),
/* keep */
> 
> Same comment as above on the one above.

This one was added because for with the "iterative solvers" classes. [Also
because, one can only provide this fairly general info.]

> [...]

Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message