commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1164615 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java
Date Fri, 02 Sep 2011 17:07:47 GMT
Hi S├ębastien.

>  
>  /**
>   * Gauss-Newton least-squares solver.
> @@ -146,8 +148,13 @@ public class GaussNewtonOptimizer extend
>                  DecompositionSolver solver = useLU ?
>                          new LUDecompositionImpl(mA).getSolver() :
>                          new QRDecompositionImpl(mA).getSolver();
> -                final double[] dX = solver.solve(b);
> -
> +                final RealVector dummy = solver.solve(new ArrayRealVector(b, false));
> +                final double[] dX;
> +                if (dummy instanceof ArrayRealVector){
> +                    dX = ((ArrayRealVector) dummy).getDataRef();
> +                }else{
> +                    dX = dummy.getData();
> +                }

In my opinion, the hypothetical efficiency gain is not worth the convoluted
code so:
---
  final double[] dX = solver.solve(new ArrayRealVector(b, false)).toArray();
---

Also, next time, when you'll really need a curly bracket ;-), please insert
a space character before it, and around keywords too:
---
if (ok) {
  // ...
} else {
  // ...
}
---

Sorry to be picky and thank you,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message