Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates
 209.85.216.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1314165743.30525.5.camel@hukku>
References: <1314165743.30525.5.camel@hukku>
Date: Thu, 25 Aug 2011 08:30:17 -0700
Message-ID: 
 <CAPVuaYt0qyaNjVUD-eP1f6uLNgoDOVDnbS6pooWQUkfcG-b4bA@mail.gmail.com>
Subject: Re: [lang]Question about StringUtils chomp and removeEnd
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Agreed :) Nice catch.

I'll also deprecate the chomp(String,String) version for removal in 4.0.

Hen

On Tue, Aug 23, 2011 at 11:02 PM, Verneri =C5berg <verneri.aberg@gmail.com>=
 wrote:
> Hi all,
>
> I was just browsing through StringUtils Api (versions 2.5, 2.6 and
> 3.0.1) and found two very similar looking methods
>
> chomp(String,String)
> and
> removeEnd(String, String)
>
> So I started to wonder what is the difference here and looked at the
> source code.
>
> To my astonishment the only difference is that chomp returns the source
> string immediately if the removed string is null and remove end
> additionally checks for empty strings too.
>
> So wouldn't it be better to substitute the duplication by simply
> replacing the chomp method with following version?
>
> public String chomp(String source, String separator) {
> =A0 =A0 =A0 =A0return removeEnd(source,separator);
> }
>
> Or is there some hidden idea for two different implementations of the
> same string chompping function? if there is maybe it should be added to
> both methods javadocs?
>
> =A0Verneri
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org