Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 921B285F5 for ; Tue, 16 Aug 2011 21:32:34 +0000 (UTC) Received: (qmail 20370 invoked by uid 500); 16 Aug 2011 21:32:33 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 20123 invoked by uid 500); 16 Aug 2011 21:32:32 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 20115 invoked by uid 99); 16 Aug 2011 21:32:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2011 21:32:32 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of paulus.benedictus@gmail.com designates 209.85.216.43 as permitted sender) Received: from [209.85.216.43] (HELO mail-qw0-f43.google.com) (209.85.216.43) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2011 21:32:25 +0000 Received: by qwf6 with SMTP id 6so272496qwf.30 for ; Tue, 16 Aug 2011 14:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=OShoBPCuXL+/1xk8hxmULHGEy6Zj/uFNUCSPR04oCso=; b=pNvn3GbzE0M5atXHmrdlFbuv7RHLqOqLiFazhi7iqrnldlIT5r05G1pByW/A4QoGxC +ASNOwNxVffIj4GEGxDyZRc8jotCVWOd7px+zEqtfCLtLxIMGjANpd18ixA2QX2uKg9c U2TJvJXphVljxGZySPgmj8zvbq226zDMhsIww= MIME-Version: 1.0 Received: by 10.52.174.204 with SMTP id bu12mr278645vdc.156.1313530324694; Tue, 16 Aug 2011 14:32:04 -0700 (PDT) Sender: paulus.benedictus@gmail.com Received: by 10.220.194.131 with HTTP; Tue, 16 Aug 2011 14:32:04 -0700 (PDT) In-Reply-To: References: Date: Tue, 16 Aug 2011 16:32:04 -0500 X-Google-Sender-Auth: smavfNnibh_s6uufPQNbLhdJRNQ Message-ID: Subject: Re: [chain] Apache Chain v2 Proof of Concept From: Paul Benedict To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org I misunderstood CHAIN-53 then. On Tue, Aug 16, 2011 at 4:29 PM, Elijah Zupancic wro= te: > Hi Paul, > > I haven't heard any discussion about a pending refactor to chain in > the last month (when I proposed the patch). Could you tell me/us more > about any plans for a major refactoring? > > Thanks, > -Elijah > > On Tue, Aug 16, 2011 at 1:42 PM, Paul Benedict wro= te: >> I may have missed the discussion... but are we releasing a Java 5 >> genericized version first before major refactoring? >> >> On Tue, Aug 16, 2011 at 3:35 PM, Elijah Zupancic = wrote: >>> Hi Simo, >>> >>> Yes, the patch is binary compatible with the old chain with one excepti= on: >>> >>> org.apache.commons.chain.web.servlet.ServletHeaderValuesMap on line >>> 97. Previously the API was returning Set>> Enumeration> when by all indications it actually should have >>> been returning Set>. I believe that I fixed a >>> previously undiscovered bug there. >>> >>> Right now, none of the unit tests are using generics and they all >>> pass. So, I assume that we have a backwards compatible API. >>> >>> Thanks, >>> -Elijah >>> >>> On Tue, Aug 16, 2011 at 2:00 AM, Simone Tripodi >>> wrote: >>>> Hi Elijah, >>>> looking at the patch, it seems that v2.0 is binary compatible to old >>>> chain, right? >>>> I mean, if in a my hypothetical application I would upgrade to v2 >>>> (generics a part) old code should continue working, right? >>>> TIA, and count also on me! >>>> All the best, have a nice day! >>>> Simo >>>> >>>> http://people.apache.org/~simonetripodi/ >>>> http://www.99soft.org/ >>>> >>>> >>>> >>>> On Mon, Aug 15, 2011 at 6:50 PM, Elijah Zupancic wrote: >>>>> Hi Matt, >>>>> >>>>> Thanks for the advice. I've created a JIRA issue for the patch >>>>> (https://issues.apache.org/jira/browse/CHAIN-53) and signed and >>>>> submitted the CLA. >>>>> >>>>> As for JSF, I believe I made a mistake in changing the API to use the >>>>> office jsf API instead of the myfaces API that was previously being >>>>> used. I went that route because I couldn't find a 2.0 version of the >>>>> faces api in the Maven repo, but it looks like it is available on the >>>>> myfaces project site, so I will revert the dependency to using myface= s >>>>> and downgrade to 2.0. >>>>> >>>>> I'll start work on migrating the test cases / mocking to a newer juni= t >>>>> and mockito, when I know that the changes will be accepted. >>>>> >>>>> Thanks again for the help! >>>>> >>>>> -Elijah >>>>> >>>>> On Mon, Aug 15, 2011 at 6:22 AM, Matt Benson w= rote: >>>>>> Hi, Elijah-- >>>>>> >>>>>> =A0I am neither a develop nor even a user of chain, so my comments w= ill >>>>>> be high-level. =A0Firstly, by all means upgrade to whatever JUnit 4 >>>>>> release version you like, e.g. 4.8.2. =A0Next, I personally am a big= fan >>>>>> of Mockito, so no complaints here on that account. =A0I can't guaran= tee >>>>>> noone else would complain, but [chain] has been fairly unloved for a >>>>>> good while. =A0As for JSF 2.1, is there something this achieves that >>>>>> wouldn't be equally well accomplished by simply upgrading to 2.0? >>>>>> This would give [chain]'s JSF support (which I personally hadn't >>>>>> realized existed) a potentially better combination of >>>>>> doing-things-that-couldn't-easily-be-done-with-older-APIs vs. broade= st >>>>>> possible applicability. >>>>>> >>>>>> Finally, as you don't seem to be a committer your final submission i= n >>>>>> this regard would be best recommended in the form of a JIRA issue, a= nd >>>>>> your patches in (albeit large) patch form. =A0In addition to this, t= he >>>>>> scope of these changes indicates it best IMO that you submit an >>>>>> Individual Contributor License Agreement governing your contribution= s >>>>>> to the ASF. =A0See http://www.apache.org/licenses/#clas for details = on >>>>>> how to do this. >>>>>> >>>>>> Regards and welcome, >>>>>> Matt >>>>>> >>>>>> On Sun, Aug 14, 2011 at 5:13 PM, Elijah Zupancic wrote: >>>>>>> I've just finished my proof of concept for an upgrade to Apache cha= in. >>>>>>> I would love to get this into a svn branch. I'm not quite sure what >>>>>>> the procedure is to do that, but the code can be found here for >>>>>>> review: >>>>>>> >>>>>>> http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-conc= ept.tar.gz >>>>>>> >>>>>>> And here is a diff: >>>>>>> >>>>>>> http://elijah.zupancic.name/projects/uber-diff >>>>>>> >>>>>>> At a high level, I have incorporated the following features in this >>>>>>> proof of concept: >>>>>>> >>>>>>> * Global upgrade to the JDK 1.5 >>>>>>> * Added @Override annotations >>>>>>> * Upgraded to the Servlet 2.5 API >>>>>>> * Upgraded to the Faces 2.1 API >>>>>>> * Upgraded to the Portlet 2.0 API >>>>>>> * Upgraded the Maven Parent POM version >>>>>>> * Added generics support to Command so that Command's API looks lik= e: >>>>>>> >>>>>>> public interface Command { >>>>>>> ... >>>>>>> =A0 =A0boolean execute(T context) throws Exception; >>>>>>> } >>>>>>> >>>>>>> * Servlet and Portlet packages now provide Genericized APIs. >>>>>>> * All dicey changes have been marked with a comment with my name: (= elijah) >>>>>>> >>>>>>> More or less the work to updated Chain was straight forward albeit >>>>>>> time consuming. >>>>>>> >>>>>>> If everyone is on board for this update, I would like to upgrade th= e >>>>>>> test cases to use a new version of JUnit. However, this leads to a = few >>>>>>> questions: >>>>>>> >>>>>>> * What version of JUnit should I use? >>>>>>> * Would it be ok to use Mockito for mocking instead of the home gro= wn >>>>>>> mocking classes already contained in the project? >>>>>>> >>>>>>> Please let me know what you think. Getting this far has been a coup= le >>>>>>> weeks worth of on and off work. >>>>>>> >>>>>>> Thanks, >>>>>>> -Elijah >>>>>>> >>>>>>> -------------------------------------------------------------------= -- >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>>>> >>>>>>> >>>>>> >>>>>> --------------------------------------------------------------------= - >>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>>> >>>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>> For additional commands, e-mail: dev-help@commons.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org