commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Sterijevski <gsterijev...@gmail.com>
Subject Re: [math] Re: SingularValueDecompositionImpl
Date Thu, 11 Aug 2011 21:31:15 GMT
At least three with some code I checked in last night. The point is that
there is no reason to replicate the same thing over and over again.

-Greg

On Thu, Aug 11, 2011 at 6:33 AM, Gilles Sadowski <
gilles@harfang.homelinux.org> wrote:

> > > In the SVD class I notice:
> > >
> > > FastMath.max(m, n)
> > >
> > > all over the place. Since these values are known when the constructor
> is
> > > called and are final, would anyone object to making the result a
> private
> > > instance variable?
>
> I see only 2 places: lines 557 and 569.
> [In one of them it is "Math.max(m, n)".]
>
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message