commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [math] Implementation of Conjugate Gradient (MATH-581)
Date Thu, 04 Aug 2011 14:54:58 GMT
> [...]
> 
> The management of the exception messages through String constants and enums is
> in my view a very clean thing. Should we do the same for exception context
> keys? Have a big enum holding keys?

I'd rather not, but I'm afraid that others will think otherwise :-}.

> Or should we define these keys as
> constant, public fields inside those classes which throw exceptions? Or, are
> we happy with inlining the string, just like in your piece of code?

If the string appears only once, I'd be happy with inlining. If more than
once, a (private) constant is better (to quiet CheckStyle).

> [...]


Best,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message