commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@scalaris.com>
Subject Fwd: svn commit: r1144995 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Date Mon, 11 Jul 2011 06:46:57 GMT

Didn't you want to make this variable static as stated in the log?

--------------- 

Betreff: svn commit: r1144995 - 
/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
Absender: ggregory-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
Datum: Mon, 11 Jul 2011 00:53:10 +0000
Newsgruppe: gmane.comp.jakarta.commons.scm

Author: ggregory
Date: Mon Jul 11 00:53:09 2011
New Revision: 1144995

URL: http://svn.apache.org/viewvc?rev=1144995&view=rev
Log:
Should be a static variable.

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java

Modified: 
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java
URL: 
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java?rev=1144995&r1=1144994&r2=1144995&view=diff
==============================================================================
--- 
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java

(original)
+++ 
commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java

Mon Jul 11 00:53:09 2011
@@ -508,7 +508,7 @@ public class DurationFormatUtilsTest ext
         //bruteForce(1996, 1, 29, "M", Calendar.MONTH);  // this will fail
     }
     
-    private int FOUR_YEARS = 365 * 3 + 366;
+    private final int FOUR_YEARS = 365 * 3 + 366;
     
     // Takes a minute to run, so generally turned off
 //    public void testBrutally() {



--------------- Weitergeleitete Nachricht (Ende)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message