commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] Closing Streams and System.in (COMPRESS-128)
Date Sat, 23 Jul 2011 14:04:05 GMT
On 23 July 2011 12:45, Stefan Bodewig <bodewig@apache.org> wrote:
> On 2011-07-23, Simone Tripodi wrote:
>
>> I personally like more the NoCloseStream approach, it would help
>> avoiding code redundancies (having the Sysout check pattern repeated
>> doesn't look nice IMHO)
>
> Yes, that would be my preference as well.

Fine by me.

It would be a change in behaviour for bzip2, so would need to be
highlighted in the Javadoc and release notes.

Perhaps the change should be left to 2.0?
It does no harm currently.

> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message