commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on RC4)
Date Tue, 19 Jul 2011 13:24:27 GMT
On Mon, Jul 18, 2011 at 9:25 PM, Henri Yandell <flamefew@gmail.com> wrote:

> Interesting issue; though thankfully it's post RC4 so not an issue wrt
> releasing 3.0.
>
> Assuming (for argument's sake) that IO Test depends on Lang & Lang
> Test depends on IO; is this bad? I'm not convinced it is. Dealing with
> something like that is something the build system needs to know how to
> do.
>

We depend on JUnit and EasyMock for testing, so I really think it is OK to
also depend on [io] for testing as well. C&P'ing code is lame in this case
IMO.

Gary


> Hen
>
> On Mon, Jul 18, 2011 at 3:50 PM, Stephen Colebourne
> <scolebourne@joda.org> wrote:
> > StringEscapeUtils test includes IOUtils, which it shouldn't. (If its
> > been added as a dependency, then it needs to be removed, even for
> > testing)
> >
> > Stephen
> >
> > On 18 July 2011 23:41, Gary Gregory <garydgregory@gmail.com> wrote:
> >> On Jul 18, 2011, at 18:36, Stephen Colebourne <scolebourne@joda.org>
> wrote:
> >>
> >>> I'm willing to vote +1
> >>> Although I haven't checked every recent change, but AFAIK recent
> >>> changes have been minor and my previous issues are resolved.
> >>>
> >>> I would note that the svn as of right now does not compile, due to an
> >>> IOUtils reference that shouldn't be
> >>
> >> Hi Stephen,
> >>
> >> Can you specify what your error is? I check both the maven and ant
> >> builds before my commit.
> >>
> >> Gary
> >>
> >>>
> >>> Stephen
> >>>
> >>>
> >>> On 16 July 2011 01:18, Henri Yandell <flamefew@gmail.com> wrote:
> >>>> Thanks Gary.
> >>>>
> >>>> So 4 +1s.
> >>>>
> >>>> Stephen, Niall, Paul, Phil, Sebb, James - nudge to consider voting
> >>>> (apologies if I missed anyone else who has committed to Lang 3.0)?
> >>>>
> >>>> Hen
> >>>>
> >>>> On Fri, Jul 15, 2011 at 12:32 PM, Gary Gregory <
> garydgregory@gmail.com> wrote:
> >>>>> That's true too. In the spirit of release early, release often,
I
> remove my
> >>>>> -1 :)
> >>>>>
> >>>>> Gary
> >>>>>
> >>>>>
> >>>>>> On Fri, Jul 15, 2011 at 10:54 AM, Henri Yandell <flamefew@gmail.com
> >wrote:
> >>>>>>
> >>>>>>> Less that it is painful (though I agree that it is), more
that if
> you
> >>>>>>> hold up a release for every bug that comes in then you continually
> sit
> >>>>>>> in a non-releasing state. We have a really bad habit of
that in
> >>>>>>> Commons, constantly polishing and polishing before a release.
> >>>>>>>
> >>>>>>> Hen
> >>>>>>>
> >>>>>>> On Fri, Jul 15, 2011 at 6:58 AM, Gary Gregory <
> garydgregory@gmail.com>
> >>>>>>> wrote:
> >>>>>>>> Here is my main issue: we are releasing a major new
version and
> there is
> >>>>>>> a
> >>>>>>>> known bug reported by a user which has been fixed in
SVN. It feels
> like
> >>>>>>> we
> >>>>>>>> are unwilling to cut a new RC because our build process
and
> validation
> >>>>>>> is
> >>>>>>>> painful (it is so in my experience at least, your mileage
may vary
> using
> >>>>>>>> custom scripts, Nexus, or other incantations.) This
is not a good
> reason
> >>>>>>> IMO
> >>>>>>>> to avoid rebuilding. In the case of a major release
like 3.0, I do
> not
> >>>>>>> want
> >>>>>>>> to leave a bad taste in a user's mouth with a class
that is not
> fully
> >>>>>>> baked,
> >>>>>>>> especially in code new to 3.0. I like that we are planning
a
> 3.0.1, but
> >>>>>>> I do
> >>>>>>>> not see why we should not include something that is
already fixed
> for
> >>>>>>> 3.0.
> >>>>>>>> It's not like this issue needs more time on investigating,
coding,
> and
> >>>>>>>> testing.
> >>>>>>>>
> >>>>>>>> Now, if you all really think I am being unreasonable,
I'll be
> happy to
> >>>>>>> go
> >>>>>>>> with the flow and reverse -1, but for now, I wanted
to express my
> full
> >>>>>>> POV.
> >>>>>>>>
> >>>>>>>> Thank you for reading and talking :)
> >>>>>>>>
> >>>>>>>> Gary
> >>>>>>>>
> >>>>>>>> On Fri, Jul 15, 2011 at 3:44 AM, Henri Yandell <
> flamefew@gmail.com>
> >>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>> Waiting on you to determine whether your -1 is still
there on
> LANG-720.
> >>>>>>>>>
> >>>>>>>>> Then need to poke Niall, Stephen et al to do a review
:)
> >>>>>>>>>
> >>>>>>>>> On Thu, Jul 14, 2011 at 11:54 AM, Gary Gregory <
> garydgregory@gmail.com
> >>>>>>>>
> >>>>>>>>> wrote:
> >>>>>>>>>> -1, let's pick up the committed fix for
> >>>>>>>>>> https://issues.apache.org/jira/browse/LANG-720
> >>>>>>>>>>
> >>>>>>>>>> I recall seeing traffic in the escape/unescape
area so it makes
> sense
> >>>>>>> to
> >>>>>>>>>> polish this new code as much as possible IMO.
> >>>>>>>>>>
> >>>>>>>>>> Gary
> >>>>>>>>>>
> >>>>>>>>>> On Thu, Jul 14, 2011 at 12:47 AM, Henri Yandell
<
> flamefew@gmail.com>
> >>>>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Lang is ready to consider 3.0 release again.
> >>>>>>>>>>>
> >>>>>>>>>>> RC4 is available here:
> >>>>>>>>>>>
> >>>>>>>>>>>  http://people.apache.org/~bayard/commons-lang3-3.0-RC4/
> >>>>>>>>>>>
> >>>>>>>>>>> SVN:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>
> http://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_0_RC4/
> >>>>>>>>>>>
> >>>>>>>>>>> Maven artifacts:
> >>>>>>>>>>>
> >>>>>>>>>>>  http://people.apache.org/~bayard/commons-lang3-3.0-RC4/maven/
> >>>>>>>>>>>
> >>>>>>>>>>> Website:
> >>>>>>>>>>>
> >>>>>>>>>>>  http://people.apache.org/~bayard/commons-lang3-3.0-RC4/site/
> >>>>>>>>>>>
> >>>>>>>>>>> Note that there is a 2.6->3.0 Clirr report
in the site that may
> >>>>>>> prove
> >>>>>>>>>>> useful:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>
> http://people.apache.org/~bayard/commons-lang3-3.0-RC4/site/lang2-lang3-clirr--report.html
> >>>>>>>>>>>
> >>>>>>>>>>> This vote will close no sooner than in 72
hours time, 0500 GMT
> 16
> >>>>>>> July
> >>>>>>>>>>> 2011.
> >>>>>>>>>>>
> >>>>>>>>>>> ================
> >>>>>>>>>>>  [ ] +1
> >>>>>>>>>>>  [ ] -1, with reason
> >>>>>>>>>>> ================
> >>>>>>>>>>>
> >>>>>>>>>>> Hen
> >>>>>>>>>>>
> >>>>>>>>>>> *fingers crossed - two of my children are
younger than the Lang
> 3.0
> >>>>>>>>>>> effort*
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>>>>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Thank you,
> >>>>>>>>>> Gary
> >>>>>>>>>>
> >>>>>>>>>> http://garygregory.wordpress.com/
> >>>>>>>>>> http://garygregory.com/
> >>>>>>>>>> http://people.apache.org/~ggregory/
> >>>>>>>>>> http://twitter.com/GaryGregory
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Thank you,
> >>>>>>>> Gary
> >>>>>>>>
> >>>>>>>> http://garygregory.wordpress.com/
> >>>>>>>> http://garygregory.com/
> >>>>>>>> http://people.apache.org/~ggregory/
> >>>>>>>> http://twitter.com/GaryGregory
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Thank you,
> >>>>>> Gary
> >>>>>>
> >>>>>> http://garygregory.wordpress.com/
> >>>>>> http://garygregory.com/
> >>>>>> http://people.apache.org/~ggregory/
> >>>>>> http://twitter.com/GaryGregory
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Thank you,
> >>>>> Gary
> >>>>>
> >>>>> http://garygregory.wordpress.com/
> >>>>> http://garygregory.com/
> >>>>> http://people.apache.org/~ggregory/
> >>>>> http://twitter.com/GaryGregory
> >>>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
Thank you,
Gary

http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message