commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: [VOTE] Release Apache Commons Digester 3.0 based on RC1 - take2
Date Fri, 01 Jul 2011 13:06:39 GMT
Le 01/07/2011 15:02, Simone Tripodi a écrit :
> Salut Luc!
>
>>
>> -1
>>
>> The gpg signature seems to have been done with key 41A0D191 which is not
>> your Apache signing key. The Apache signature key present in the KEYS file
>> is either 19FEA27D or C002CC79.
>>
>
> my bad :/
>
>> There are also a few other minor issues:
>>
>>   - a few checkstyle errors, mainly misplaced Apache headers
>>    (the headers are there, but not at beginning of file),
>
> it is a false positive, they are detected in package-info.java files -
> I didn't figure out how to put them in the ignore list :( Any
> suggestion?

Moving them at file start to make checkstyle happy ? Sometimes, I find 
it easier to fix false positive rather than fixing the tool configuration.

>
>>   - a few javadoc warnings when generating the site with
>>    "mvn clean site",
>
> ouch! :(
>
>>   - if I add findbugs in the pom file, it detects four small problems,
>
> that have definitively be fixed, thanks!
>
>>   - the maven artifacts still contains files with double checksums
>>    .asc.md5 and .asc.sha1.
>
> IIUC they can be deleted also from Nexus, right?

Yes, this can be done manually. You can select individual files and 
delete them before closing the staging area if I remember correctly.

Luc

>
>
>>
>> Luc
>>
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message