commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sébastien Brisard <sebastien.bris...@m4x.org>
Subject Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/math/analysis/solvers/
Date Fri, 24 Jun 2011 07:12:14 GMT
+1

2011/6/24 Luc Maisonobe <Luc.Maisonobe@free.fr>:
> Hi all,
>
> The provided patch for MATH-599 includes a number of no-brace if statements
> like the following ones:
>
>> +                if (method == Method.ILLINOIS) f0 *= 0.5;
>> +                if (method == Method.PEGASUS) f0 *= f1 / (f1 + fx);
>
> I'm not sure if we have an unwritten rule for this, but personally I dislike
> this style a lot. Checkstyle provides a NeedBraces rule to avoid this.
>
> What about activating this rule ?
>
> Luc
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message