commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@gmail.com>
Subject Re: [IP clearance] Fwd: [jira] [Commented] (JXPATH-149) Relational operation misbehaves
Date Wed, 08 Jun 2011 17:50:15 GMT
On Wed, Jun 8, 2011 at 12:49 PM, Matt Benson <gudnabrsam@gmail.com> wrote:
> On Wed, Jun 8, 2011 at 10:07 AM, James Carman
> <james@carmanconsulting.com> wrote:
>> Perhaps you can re-write this patch yourself in a clean-room environment? :)
>
> I had originally replied to the effect that having already seen and
> applied the patch, I was not really free from having seen the patch.

How's that for redundancy?  You know what I mean.

Matt

> I only just now noticed that I had failed to respond to the entire
> list, and had replied only to James personally.  In the interim I
> managed to accidentally blow away the patched version of the class in
> question, so now actually *have* rewritten the patch "blind" and
> suppose I will go ahead and commit it.  :|
>
> Matt
>
>>
>> On Wed, Jun 8, 2011 at 10:59 AM, Matt Benson <gudnabrsam@gmail.com> wrote:
>>> Hi all,
>>>  I haven't waited long, but it is possible the user who submitted the
>>> patch for this bug may not respond, and in this case his patch
>>> consists only of a minor tweak to a copy of a method from the same
>>> class, so I think requiring the feather on the JIRA patch is a bit of
>>> overkill in this case.  Is there a "threshold of originality" below
>>> which we can simply assume clearance?
>>>
>>> Matt
>>>
>>>
>>> ---------- Forwarded message ----------
>>> From: Matt Benson (JIRA) <jira@apache.org>
>>> Date: Tue, Jun 7, 2011 at 6:09 PM
>>> Subject: [jira] [Commented] (JXPATH-149) Relational operation misbehaves
>>> To: issues@commons.apache.org
>>>
>>>
>>>
>>>    [ https://issues.apache.org/jira/browse/JXPATH-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045698#comment-13045698
>>> ]
>>>
>>> Matt Benson commented on JXPATH-149:
>>> ------------------------------------
>>>
>>> Hi, I have reviewed your proposed fix and it looks good.  For
>>> formality's sake, can you please declare that your changes are
>>> intended for inclusion into the Apache Commons JXPath library?
>>>
>>> Also, in the future, please provide your changes in the form of diff patches.
>>>
>>> Thanks!
>>>
>>>> Relational operation misbehaves
>>>> -------------------------------
>>>>
>>>>                 Key: JXPATH-149
>>>>                 URL: https://issues.apache.org/jira/browse/JXPATH-149
>>>>             Project: Commons JXPath
>>>>          Issue Type: Bug
>>>>    Affects Versions: 1.3
>>>>            Reporter: Alexander Koledzhikov
>>>>            Priority: Minor
>>>>         Attachments: CoreOperationRelationalExpression.java, TestClass.java
>>>>
>>>>
>>>> I have a simple JXpathContext, with the following variables: var1=0, var2=0,
var3=1. When I try to evaluate the following expression - "$var1 + $var2 <= $var3", it
returns false.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message