commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [DIGESTER][SANDBOX] back proposing the Digester3 merge to trunk
Date Thu, 02 Jun 2011 11:25:35 GMT
On 2 June 2011 08:13, Simone Tripodi <simonetripodi@apache.org> wrote:
> Hi Rahul,
> I forgot to notify you the clirr report[1] is now online,
> unfortunately is not really useful due to repackaging :(

See

https://issues.apache.org/jira/browse/VFS-344

for one way to allow comparison across packages

> I'll wait for more feedbacks from you before calling a vote for the
> merge - in the meanwhile I'll continue developing on Sandbox with the
> aim to prepare the 3.0 release.
> Have a nice day, all the best!!!
> Simo
>
> [1] http://commons.apache.org/sandbox/digester3/clirr-report.html
>
> http://people.apache.org/~simonetripodi/
> http://www.99soft.org/
>
>
>
> On Wed, Jun 1, 2011 at 4:25 PM, Simone Tripodi <simonetripodi@apache.org> wrote:
>> Hi Rahul!
>> thanks for your kind feedback :) I'm going to plug the clirr plugin
>> and redeploy the site so we can have a better overview about what
>> changed.
>> The last point is indeed very important for users, the first attempt
>> broke that kind of compatibility that maybe was too rude :P
>> I'll let you know as soon as the new site is online!
>> Thanks!
>> Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://www.99soft.org/
>>
>>
>>
>> On Wed, Jun 1, 2011 at 4:15 PM, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
>>> On Wed, Jun 1, 2011 at 1:46 AM, Simone Tripodi <simonetripodi@apache.org>
wrote:
>>>> Hi Rahul :)
>>>> thanks for following up!
>>>>
>>>> I can confirm they're NOT binary compatible even without running
>>>> clirr, because of the following reasons:
>>>>
>>> <snip/>
>>>
>>> We'll need to analyze with clirr anyway, minimally to produce good
>>> release notes and 2.x -> 3.0 migration notes.
>>>
>>> Not all breaks are equal, so in below:
>>>
>>>>  - deprecated APIs don't exist anymore;
>>> <snap/>
>>>
>>> Permissible in major release.
>>>
>>>>  - internals of annotations/xml modules have been rewritten as EDSL extensions;
>>>>  - some Digester methods changed signature, like Digester.pushParams(
>>>> Object object ) versus the new Digester.pushParams( Object... object )
>>> <snip/>
>>>
>>> Above may be OK.
>>>
>>>>  - due to all these changes, I took advantage to repackage classes to
>>>> org.apache.commons.digester3
>>>>
>>> <snap/>
>>>
>>> +1 to repackage.
>>>
>>>> Anyway I didn't break the pure Digester use as I did in the previous
>>>> attempt, users are still able to bin rules using the usual pattern
>>>>
>>>>    Digester d = new Digester();
>>>>    d.addObjectCreate("foo", "mypackage.Foo");
>>>>    ...
>>>>
>>> <snip/>
>>>
>>> This is useful IMO.
>>>
>>> -Rahul
>>>
>>>
>>>> I would really appreciate if you have spare time to have a look at the
>>>> code, I immagine you are quiet busy but there's no rush ;)
>>>> Have a nice day, all the best!!!
>>>> Simo
>>>>
>>>> http://people.apache.org/~simonetripodi/
>>>> http://www.99soft.org/
>>>>
>>>>
>>>>
>>>> On Wed, Jun 1, 2011 at 12:08 AM, Rahul Akolkar <rahul.akolkar@gmail.com>
wrote:
>>>>> On Tue, May 31, 2011 at 5:46 PM, Simone Tripodi
>>>>> <simonetripodi@apache.org> wrote:
>>>>>> New site is online, does someone have some spare time to check[1]
and
>>>>>> provide feedbacks about the merge proposal?
>>>>> <snip/>
>>>>>
>>>>> Don't have much time, but if its now compatible with 2.x thats a good
>>>>> thing :-) You may want to confirm using a clirr or equivalent report.
>>>>>
>>>>> -Rahul
>>>>>
>>>>>
>>>>>> Thanks in advance, have a nice day!!!
>>>>>> Simo
>>>>>>
>>>>>> [1] http://commons.apache.org/sandbox/digester3/
>>>>>>
>>>>>> http://people.apache.org/~simonetripodi/
>>>>>> http://www.99soft.org/
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, May 31, 2011 at 6:41 PM, Simone Tripodi
>>>>>> <simonetripodi@apache.org> wrote:
>>>>>>> Hi all guys,
>>>>>>> after some day of work on Sandbox, I'm back to propose once again
the
>>>>>>> merge of my work in proper /trunk.
>>>>>>> Failing my first attempt was good, because I had the opportunity
to
>>>>>>> learn a lot and this time the proposal is much better :P
>>>>>>>
>>>>>>> What I did:
>>>>>>>
>>>>>>>  - moved the current sandbox in a separate branch;
>>>>>>>  - copied the current trunk in sandbox;
>>>>>>>  - polished APIs (few trivial checkstyle violations yet), removed
>>>>>>> @Deprecated methods, added more power with generics;
>>>>>>>  - re-introduced - simplifying! - the Digester EDSL;
>>>>>>>  - removed old custom DigesterLoader for annotations/xml package.
>>>>>>>
>>>>>>> So, at the end of the day, this time users are still able to
create
>>>>>>> Digester instances using the old-fashioned APIs - even if they're
>>>>>>> encouraged to use the more expressive fluent APIs - except when
using
>>>>>>> annotations/XML extensions.
>>>>>>>
>>>>>>> I still have to publish the site - it's the site on /trunk +
EDSL
>>>>>>> documentation - I'll do it as soon as I'll get home (I'm leaving
the
>>>>>>> office now) so you can see how APIs/Doc look
>>>>>>>
>>>>>>> Anyway interested people can start having a look at the component
code on SVN[1]
>>>>>>>
>>>>>>> Please send huge feedbacks!!!
>>>>>>> Have a nice day!
>>>>>>> Simo
>>>>>>>
>>>>>>> [1] https://svn.apache.org/repos/asf/commons/sandbox/digester3/trunk
>>>>>>>
>>>>>>> http://people.apache.org/~simonetripodi/
>>>>>>> http://www.99soft.org/
>>>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message