commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: [math] Re: [jira] [Commented] (MATH-485) Feature Request: Kalman Filter
Date Sat, 11 Jun 2011 20:13:29 GMT
Hi Gilles,

Le 11/06/2011 22:22, Gilles Sadowski a écrit :
> [Posting here because the JIRA web server is down.]
>
> On Sat, Jun 11, 2011 at 06:32:59PM +0000, Luc Maisonobe (JIRA) wrote:
>>
>>      [ https://issues.apache.org/jira/browse/MATH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047964#comment-13047964
]
>>
>> Luc Maisonobe commented on MATH-485:
>> ------------------------------------
>>
>>  From a quick look, this seems good to me.
>> There are still some missing javadoc (on private fields) and missing</i>  in
the html. It would also be nice to have in the javadoc for KalmanFilter class an explanation
of the meaning of the matrices and vectors (A = transition matrix, B control matrix, u control
vector ...).
>>
>> There is one point that bothers me. The ProcessModel and MeasurementModel interfaces
define methods to retrieve the process noise and measurement noise that don't have any parameter.
Thus the user can only implement constant noises, not time-dependant noises when he implement
the interfaces (or use the default implementation, which are constant). Wouldn't it be more
general to add an integer parameter for the step number ? The default implementation would
ignore it and always return the same matrices, but users may want to have custom implementation
using the informatio of the current step.
>>
>> Concerning the formatting you should check the style with checkstyle. Typically,
tabulation is completely forbidden and for line breaks, the operators should remain at the
end of the previous line, not at the beginning of the next line.
>
> I've just corrected most CheckStyle complaints. Can I commit the code? Work
> can then continue form the checked-in version.

Sure, thanks a lot.

Luc

>
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message