commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [pool] equal instances
Date Sat, 11 Jun 2011 18:04:45 GMT
On 11/06/2011 18:18, Phil Steitz wrote:
> On 6/11/11 2:54 AM, Mark Thomas wrote:
>> On 11/06/2011 08:44, Phil Steitz wrote:

>> I too think that the second option is the way to go using system
>> identity hashcodes. I'm not sure that the first option will be faster
>> since iterating through the List of circulating objects is likely to be
>> slower than generating a system identity hashcode and doing a lookup in
>> a Map. If testing pool2/dbcp2 shows that the system identity hashcode
>> makes it significantly slower than Tomcat's jdbc-pool then we can look
>> at this again.
> 
> What I meant in the second comment was to basically leave the code
> as is with the restriction that instances must be equals-discernible
> by default and provide either a subclass or a config option that
> would trigger the more complicated code to check identity hashes.

Ah right. Sorry. I misunderstood. That could be a plan.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message