commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/math/analysis/solvers/
Date Fri, 24 Jun 2011 09:13:27 GMT
Hi.

> >I agree with you that braces should always be used. Personally, I do
> >have one exception though, and that is if the statement following it is
> >on the same line. That way, it is one line, instead of 3 lines, which
> >makes it more readable. If the 'if' statement spans multiple lines, I
> >always include braces, even if there is only one single statement
> >involved. But that is just me...
> 
> So we have at least two different opinions here, which is good.
> Let's see what other people think.

I prefer to have _one_ rule for code formatting.
[Also, you nvere know when you might need an additional statement wihtin the
conditional branch (e.g. when debugging).]

> >
> >I think the rule is already active in Checkstyle. I think I just chose
> >to ignore it here.
> 
> No, the rule is not active in our checkstyle configuration. I have
> tested it, there are about 130 violations of this rule in our code
> base, so it is really simple to fix all of them.

+1 for enabling the rule.

> [...]

Best regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message