Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of phil.steitz@gmail.com
 designates 209.85.160.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:references:from:content-type:x-mailer:in-reply-to
         :message-id:date:to:content-transfer-encoding:mime-version;
        b=vvPRR14/xdBTbnNWmzDX2vlT0yhTLX+wkum0ORxkTL32kU3Gkw9xGaddYKkpnwn7Vs
         a0TEfOFlB2JncvmPyTua/IgPnESu8xu8bnEmY4VZdDRRRCLCEbQbd7snByGhHkf2U1d2
         /ipwwBPNT98xwNFw06TqAX5xZbNOD3SSyQ6FM=
Subject: Re: [pool] GKOP POOL-180 test (testMaxActivePerKeyExceeded) broken
References: <4DD2DF52.2030809@gmail.com>
 <BANLkTi=o7LBRbNtRD1Kr+8q_d2=ainkEmA@mail.gmail.com>
From: Phil Steitz <phil.steitz@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: <BANLkTi=o7LBRbNtRD1Kr+8q_d2=ainkEmA@mail.gmail.com>
Message-Id: <F12C4DE2-E0E0-4B32-A143-07819E14B73D@gmail.com>
Date: Tue, 17 May 2011 18:00:24 -0700
To: Commons Developers List <dev@commons.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (iPhone Mail 8J2)

I have fixed this locally and will commit.  The problem was that the tests s=
hare a protected pool field that is <String, String> but that test needs <St=
ring,Waiter>.  That must have caused compilation failure so the pool variabl=
e was redeclared locally instead of just set.  In any case, I have fixed it a=
nd will commit once I have finished testing Mark's latest changes.


On May 17, 2011, at 5:48 PM, sebb <sebbaz@gmail.com> wrote:

> On 17 May 2011 21:49, Phil Steitz <phil.steitz@gmail.com> wrote:
>> The generics changes made this test no longer test with the expected
>> pool config.  The runTestThreads method uses the protected pool
>> field and the pool set up in the test was changed to a local
>> variable in the generics changes.
>=20
> Not sure that was a generics change, though it may have been made at
> the same time. IIRC there were several public or protected fields that
> were deprecated in a previous release, and have now been made private.
> Was it one of those?
>=20
> If possible, perhaps add a package-protected getter/setter for use by
> the test code only?
>=20
>> Phil
>>=20
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>=20
>>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>=20

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org