Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6C686680 for ; Tue, 24 May 2011 14:26:06 +0000 (UTC) Received: (qmail 62847 invoked by uid 500); 24 May 2011 14:26:06 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 62745 invoked by uid 500); 24 May 2011 14:26:06 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 62737 invoked by uid 99); 24 May 2011 14:26:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2011 14:26:06 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of philippe.mouawad@gmail.com designates 209.85.161.171 as permitted sender) Received: from [209.85.161.171] (HELO mail-gx0-f171.google.com) (209.85.161.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 May 2011 14:25:59 +0000 Received: by gxk22 with SMTP id 22so2942481gxk.30 for ; Tue, 24 May 2011 07:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=lBCCEAa5rG1/sC3P/XYd815hwWNhYn4n6D9VcffuRzQ=; b=Tf41QPoJ8KE60wJeg2IyCg8iUjxa6X773G7QyzIbEJhoHbxIVyJLT6RJHOjMpeilOC vJqADnYcxLHVfrWWdJe8TNNtqRxccr00GxihKEIOYhkD6gOEXjcgQIQeR6NhSAfhA2WF 4T+ySSsZdBTnE7S+gFSRQ81rjQT4FY1E/rbqU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=RJYtgDacoKq9/O7hTRU69oSHEahL+YYVd0HOjK3yWr3NaYT7R4vDaQcrehSazGmcx7 twqpkrr970qr1Ht5LRmhvCFYEyX4dNFQxeLgOQTsPZGuR8il7Gx956D1+ux+pebRe4/N TFafR1FmDSXKEA5GK/2p+37SHHhSOV5EcYsCA= MIME-Version: 1.0 Received: by 10.236.183.166 with SMTP id q26mr4892413yhm.87.1306247139023; Tue, 24 May 2011 07:25:39 -0700 (PDT) Received: by 10.236.105.129 with HTTP; Tue, 24 May 2011 07:25:38 -0700 (PDT) In-Reply-To: <4DDBBE34.4030609@apache.org> References: <4DDBBE34.4030609@apache.org> Date: Tue, 24 May 2011 16:25:38 +0200 Message-ID: Subject: Re: Question about DBCP code usage From: Philippe Mouawad To: Commons Developers List Content-Type: multipart/alternative; boundary=20cf305b0a52b5db5804a4065cb4 --20cf305b0a52b5db5804a4065cb4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello, Thanks for the quick response. In fact I would like to contribute the code to Tomcat JDBC Pool and it firs= t that is Ofbiz project, because Ofbiz uses largely this Local XA feature. But of course I will be asking them if they are interested and maybe nobody will be :-) Regards Philippe On Tue, May 24, 2011 at 4:18 PM, Mark Thomas wrote: > On 24/05/2011 15:09, Philippe Mouawad wrote: > > Hello, > > I have a question regarding code usage of DBCP. > > > > For another pool implementation that is an Apache project, > Out of interest, which one? > > > I would like to > > submit a patch related to LocalXA implementation. > > This patch will use (by changing their package location) the following > > classes from DBCP: > > > > - TransactionRegistry > > - LocalXAResource > > - TransactionContext > > - TransactionContextListener > > > > And have a class partly inspired by ManagedConnection. > > > > > > My question is: > > > > - Can I do this if I keep the author name and Apache mention ? if no > what > > must I do ? > > If you are re-using code from one Apache project in another then that is > fine. You can just copy the classes and modify as you require. It is > always a good idea to reference where the classes come from somewhere > but it is not required. > > Tomcat for example includes code copied from DBCP, Digester and > FileUpload to name but a few. > > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --=20 Cordialement. Philippe Mouawad. Ubik-Ing=E9nierie --20cf305b0a52b5db5804a4065cb4--