commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maurizio Cucchiara <maurizio.cucchi...@gmail.com>
Subject [OGNL] God Class
Date Tue, 17 May 2011 23:01:41 GMT
if there is something I hate in programming is the god class [1].
OGNL seems to embrace god object's cause pretty well.

----------------------------------------------------------------------------------------------------------------------
find -size +30k -name "*.java"| xargs -i sh -c "wc -l {}" | sort -n
771 ./src/main/java/org/apache/commons/ognl/Ognl.java
1139 ./src/main/java/org/apache/commons/ognl/OgnlOps.java
1858 ./src/main/java/org/apache/commons/ognl/OgnlParserTokenManager.java
3038 ./src/main/java/org/apache/commons/ognl/OgnlRuntime.java
4845 ./src/main/java/org/apache/commons/ognl/OgnlParser.java

----------------------------------------------------------------------------------------------------------------------

5000 lines of code... we should consider to rename to Bible.java
Jokes apart, it's very difficult to handle a class like this, if you
change something it's highly probable to broke the whole logic.  I
think that everybody is afraid of manage a such big class.

We could maintain the API backward compatibility even trying to
improve this aspect.

What do you think?

[1] http://en.wikipedia.org/wiki/God_object

-- 
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message