commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [SCXML] Tidy up test cases
Date Mon, 23 May 2011 15:41:24 GMT
On 23 May 2011 16:22, Rahul Akolkar <rahul.akolkar@gmail.com> wrote:
> On Mon, May 23, 2011 at 8:16 AM, sebb <sebbaz@gmail.com> wrote:
>> SCXML has had a couple of ongoing Gump failures, which I started to
>> look at again.
>>
> <snip/>
>
> Thanks, the initial breakage was from EL trunk changes, if you follow
> this trail (if you've begun to look into it, this probably won't be
> new information):
>
>  http://markmail.org/message/v2ioxdq2s7c62mtl
>
> Ofcourse, EL isn't active and I haven't looked into it.

OK, I'll look into that.

>
>> [As part of this, I noticed and fixed some minor issues in the Ant build file.]
>>
> <snap/>
>
> I understand some of the changes you've made, but can't guarantee they
> will persist as the Ant build file is generated and is regen'ed every
> release cycle.

I see. In that case perhaps the generate process needs to be fixed.
e.g. IMO it does not make sense to release a build file that does not
specifiy the source and target Java versions or which does not specify
"includeantruntime"

>
>> The component currently uses nested test suites (and main() methods)
>> which are unnecessary.
>> They also make finding the errors harder, as one has to find which
>> suite includes the test.
>>
>> I'd like to remove all the main methods and all the suites which
>> merely group other tests.
>>
>> OK?
>>
> <snip/>
>
> This doesn't bother me (we're not writing new tests or updating this
> everyday), but if you want to go ahead, thats fine with me.
>
> I ask that you also track and port applicable changes from trunk to
> the J6 branch, when making any changes to [SCXML].

OK.

> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message