commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [LANG] change FormatCache.getDateTimeInstance() to use int
Date Wed, 18 May 2011 15:17:29 GMT
On Wed, May 18, 2011 at 9:37 AM, sebb <sebbaz@gmail.com> wrote:

> I think the method (new to 3.0)
>
> FormatCache.getDateTimeInstance(Integer dateStyle, Integer timeStyle,
> TimeZone timeZone, Locale locale)
>
> should be changed to use ints, as all the existing callers use ints.
>
> Furthermore, the parameters have to be unboxed in order to pass them
> to DateFormat, so the boxing/unboxing is unnecessary and wasteful.
>
> OK?
>

+1


>
> I've not raised a JIRA for this because it is new code that has not
> been released - but I'm happy to do so if others think a JIRA entry is
> necessary here.
>

No JIRA needed IMO.

Gary


>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
Thank you,
Gary

http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message