commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rahul Akolkar <rahul.akol...@gmail.com>
Subject Re: [SCXML] Tidy up test cases
Date Mon, 23 May 2011 15:22:35 GMT
On Mon, May 23, 2011 at 8:16 AM, sebb <sebbaz@gmail.com> wrote:
> SCXML has had a couple of ongoing Gump failures, which I started to
> look at again.
>
<snip/>

Thanks, the initial breakage was from EL trunk changes, if you follow
this trail (if you've begun to look into it, this probably won't be
new information):

  http://markmail.org/message/v2ioxdq2s7c62mtl

Ofcourse, EL isn't active and I haven't looked into it.


> [As part of this, I noticed and fixed some minor issues in the Ant build file.]
>
<snap/>

I understand some of the changes you've made, but can't guarantee they
will persist as the Ant build file is generated and is regen'ed every
release cycle.


> The component currently uses nested test suites (and main() methods)
> which are unnecessary.
> They also make finding the errors harder, as one has to find which
> suite includes the test.
>
> I'd like to remove all the main methods and all the suites which
> merely group other tests.
>
> OK?
>
<snip/>

This doesn't bother me (we're not writing new tests or updating this
everyday), but if you want to go ahead, thats fine with me.

I ask that you also track and port applicable changes from trunk to
the J6 branch, when making any changes to [SCXML].

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message