commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [math] Restoring IAE to MathUtils#binomialCoefficient methods
Date Mon, 02 May 2011 23:08:29 GMT
> > [...]
> >>Consistency implies that *all* exceptions thrown from CM must behave the
> >>same way. I thus propose to add an interface like (maybe a better name?):
> >>---
> >>interface ContextedException {
> >>   void addMessage(Localizable pattern,
> >>                   Object ... arguments);
> >>   void setContext(String key, Object value);
> >>   Object getContext(String key);
> >>   Set<String>  getContextKeys();
> >>   String getMessage(final Locale locale);
> >>   String getMessage(final Locale locale,
> >>                     final String separator);
> >>}
> >>And all CM exceptions will implement this interface. [Instead of
> >>automatically inheriting the behaviour by being subclasses of
> >>"MathRuntimeException".]
> >>
> >I would prefer as stated above to revert to actual RTEs per 2.x
> >behavior.  Above would be an improvement, as at least the unexpected
> >RTEs at upgrade would not bite (as they did me), but I see no reason
> >to add this machinery which is no less complex than what we had in
> >2.x.  Lets see what others think.
> 
> Do the above mean we would have:
> 
>   public class MathIllegalArgumentException
>     extends IllegalArgumentException
>     implements ContextedException

Yes. [Not sure about the name "ContextedException" yet.]

> If so, then I am OK with this.


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message