Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of flamefew@gmail.com designates
 209.85.216.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=kGRp8aSL653CEWncBexyPAMAt81rynU/eHoCS8UWOrvjhMDRiVEVj/K5TJ99K6sfmU
         Uhn6x3xlxTFLgkSrANtBErzkzTkkq189zZxPx7ODag8Wxz0XpyZCRyAFI5C/ndRmX0km
         pSK1iUjiSKCcZQP8Vg7y+asMxM0iYMfDPHK9M=
MIME-Version: 1.0
In-Reply-To: <4DBC5DF4.7040009@oliver-heger.de>
References: <BANLkTimiJ25jSA=y0iqX8rzzvJKy2t0OYA@mail.gmail.com>
	<4DBB1594.6030801@oliver-heger.de>
	<BANLkTikk5ysuY1=-593PBz6H=xzJbpZ2Lg@mail.gmail.com>
	<4DBC5DF4.7040009@oliver-heger.de>
Date: Sat, 30 Apr 2011 14:29:15 -0700
Message-ID: <BANLkTimcvJL5tzTQjuWoWuYYWBWmcKZeiA@mail.gmail.com>
Subject: Re: [CANCEL] Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on
 RC3)
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Apr 30, 2011 at 12:07 PM, Oliver Heger
<oliver.heger@oliver-heger.de> wrote:
> Am 29.04.2011 23:00, schrieb Henri Yandell:
>>
>> Oops - I built on 1.6 and should have built on 1.5. I'll rebuild from
>> the tag and see if I get the error you get.
>>
>> Hen
>
> Sorry, still no luck, I get the same error. The test case only fails if the
> test class is executed as a whole. It succeeds if it is executed standalone.
> In the latter case a format object is newly created while it is obtained
> from the cache in the former case.
>
> I assume that the problem has something to do with the fact that my default
> locale is German which is also used explicitly by some of the tests. It
> seems that JDK 1.5 creates a new Locale instance when the default locale is
> changed. Thus the format object checked by the test has a German locale, but
> it is not the same instance as passed to the assertSame() condition.
>
> I suggest changing the test to use assertEquals() rather than assertSame().
> This works in any case and should be a condition strong enough.

Sounds good. I dont think it's a release blocker but a fine change to
make to trunk.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org