Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of flamefew@gmail.com designates
 209.85.216.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=OJCm+4XYS0EMBIIywaDc4uSnmLa4Iy9tWMndLxMRL5EJ9sApqV/7qtbEkdujJ/d/08
         lCdhIRuTnyAE26DYoDrJ5QLtZNhwwNTRgEvx2LY3KCuuhMbNhVbjd4aajDStRHFtmcGR
         2Ns1fzQJoBBdqvkrMeK/WFcZZUvhT4caBoU6Q=
MIME-Version: 1.0
In-Reply-To: <4DA1CD2D.4060709@free.fr>
References: <BANLkTimMT5W0EGXjkZy1tg99sokv8tci_g@mail.gmail.com>
	<4DA1CD2D.4060709@free.fr>
Date: Sun, 10 Apr 2011 09:22:53 -0700
Message-ID: <BANLkTim9ZPHvr+ZtRuOy6e_hc0kUQ4mnJA@mail.gmail.com>
Subject: Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on RC2)
From: Henri Yandell <flamefew@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Cc: Luc Maisonobe <Luc.Maisonobe@free.fr>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 10, 2011 at 8:30 AM, Luc Maisonobe <Luc.Maisonobe@free.fr> wrot=
e:
> Le 09/04/2011 07:06, Henri Yandell a =E9crit :
>> Lang is ready to consider 3.0 release again.
>>
>> RC2 is available here:
>>
>> =A0 http://people.apache.org/~bayard/commons-lang3-3.0-RC2/
>>
>> Maven artifacts:
>>
>> =A0 http://people.apache.org/~bayard/commons-lang3-3.0-RC2/maven/
>>
>> Website:
>>
>> =A0 http://people.apache.org/~bayard/commons-lang3-3.0-RC2/site/
>>
>> Note that there is a 2.6->3.0 Clirr report in the site that may prove us=
eful:
>>
>> =A0 http://people.apache.org/~bayard/commons-lang3-3.0-RC2/site/lang2-la=
ng3-clirr-report.html
>>
>> This vote will close in 72 hours, 0400 GMT 31-March 2010
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> =A0 =A0 [ ] +1
>> =A0 =A0 [ ] -1, with reason
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> -0
>
> In the userguide, the subsection titles style refer to lang as the
> top-level package name instead of lang3.

Not a blocker as this is website only.

> From the comments above it, I guess the str =3D=3D "true" check at the
> beginning of BooleanUtils.toBooleanObject(String str) is voluntary and
> is an optimization. It should be declared as such by adding an exclusion
> filter in findbugs so it does not appear.

Not a blocker.

> The various null returns other methods of the same BooleanUtils class
> also seem to be OK since they are documented in javadoc. So they should
> also be filtered out from findbugs report.

Not a blocker; please feel free to dive in and handle both if you're willin=
g.

> When I generate the site locally, I get an additional findbugs error not
> shown in the site linked above. This error reads:
>
> Null pointer dereference of System.err in
> org.apache.commons.lang3.SystemUtils.getSystemProperty(String)
> CORRECTNESS =A0 =A0 NP_ALWAYS_NULL =A01247 =A0 =A0High
>
> I don't understand this error. The findbugs version seem to be the same
> in both cases (1.3.9).

Very odd. There's nothing obvious with the code there; though maybe
it's confused and there's somewhere where getSystemProperty is used
(via a variable) and is referenced without being null.

I don't see this as a blocker as it's not defined enough.

> Concerning the error in ExtendedMessageFormat, it seems the superclass
> does call applyPattern from its constructor. As one cannot initialize
> any field before the superconstructor is called, it seems impossible to
> fix this error. As there is a check against null at the very beginning,
> it is probably OK and should be filtered out. However, I would like to
> see someone else analyze this error too.

The code seems fine given we can't touch the superclass.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org