Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 89799 invoked from network); 5 Apr 2011 13:59:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Apr 2011 13:59:09 -0000 Received: (qmail 12208 invoked by uid 500); 5 Apr 2011 13:59:09 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 12136 invoked by uid 500); 5 Apr 2011 13:59:09 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 12128 invoked by uid 99); 5 Apr 2011 13:59:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 13:59:09 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com designates 209.85.215.43 as permitted sender) Received: from [209.85.215.43] (HELO mail-ew0-f43.google.com) (209.85.215.43) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2011 13:59:01 +0000 Received: by ewy20 with SMTP id 20so230045ewy.30 for ; Tue, 05 Apr 2011 06:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=oiWf0pKukDoyzInaVNoI1AhdJCc4+NfjAj0EO5Fi6hk=; b=HltQE52dct2CleeSvnjNdYidg1NqGkQDYP/11nh5+7MJDn0WS4uSRfj2B7MKUgnMmm Y7BMEM1ozX8Yegp/J3X0y+yV+wgUux94Rd42Zfz5l9caARO/biZSqYeHz0MDwqJ3MHom HEcpXe7YxvME3qrZ3qf2HiK9A88JWX5YpJ07s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Y3vTQqiMcblSCmTx/f+kxwrpz16q/+m7lLvXw6zidirpCPK4NG4ZJG04LipvCoXq2N rueOnXBkw3jJ7OhlcWqg/v7/4ICkdfIFfjODkrRIkGvpnf+i0zTAZamQSU0Zw7sNaU1p CA0oQIvD27s4TfXlgfYLYML3zMEfdpopFePSo= MIME-Version: 1.0 Received: by 10.14.47.202 with SMTP id t50mr3886825eeb.51.1302011921297; Tue, 05 Apr 2011 06:58:41 -0700 (PDT) Received: by 10.14.37.78 with HTTP; Tue, 5 Apr 2011 06:58:41 -0700 (PDT) In-Reply-To: References: Date: Tue, 5 Apr 2011 09:58:41 -0400 Message-ID: Subject: Re: [ALL] @version tag :) From: Gary Gregory To: Commons Developers List Cc: sebb Content-Type: multipart/alternative; boundary=90e6ba6153ae0ff2aa04a02c46b0 X-Virus-Checked: Checked by ClamAV on apache.org --90e6ba6153ae0ff2aa04a02c46b0 Content-Type: text/plain; charset=UTF-8 On Tue, Apr 5, 2011 at 6:19 AM, sebb wrote: > On 5 April 2011 10:44, sebb wrote: > > On 5 April 2011 09:55, Simone Tripodi wrote: > >> Hi all guys! > >> > >> @Torsten: I agree, question is that I have never understood why the > >> common usage is putting SVN tags in @version javadoc, so since I > >> noticed a mixed usage, I wondered which one is the commonly used; > >> > >> @Christian: I intended @version, because existing source have *a lot* > >> of that tag; for @since instead the common usage seems to be correct > >> > >> BTW I would be +1 for NO @version and putting only @since > > > > I think the intention of the @version tag is to identify code that is > > not stored in SVN - e.g. in a source archive. > > > > $Revision$ and $Id$ (or even $HeadUrl) are fine in @version comments, > > however please don't use $Date$ as that is expressed in local time. > > This really messes up release checking as the dates in source archives > > don't match the dates in SVN tag checkouts unless the same timezone is > > being used. > > In case it's not obvious, I am > > -1 to banning @version, as it can be useful > Since $Id$ contains the user ID we I would an @version that contains the revision number. I find that useful. I like to see a revision number in the manifest too (if it's not there already), like http://maven.apache.org/plugin-developers/cookbook/add-svn-revision-to-manifest.html Gary > +1 to banning $Date$ in @version > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > -- Thank you, Gary http://garygregory.wordpress.com/ http://garygregory.com/ http://people.apache.org/~ggregory/ http://twitter.com/GaryGregory --90e6ba6153ae0ff2aa04a02c46b0--